evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: amplc_pci224: Change return type of pci224_find_pci()

Browse source 
pci224_find_pci() finds a supported PCI device, returning 0 on success
or -EIO on failure and returning the pointer to the PCI device via a
struct pci_dev ** parameter.  Change it to return the struct pci_dev *
on success or NULL on failure.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott 2012-05-31 16:02:04 +01:00 • committed by Greg Kroah-Hartman
parent eedc1b7be2
commit 01ea83bce2
1 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/staging/comedi/drivers/amplc_pci224.c
View file

@ -1255,14 +1255,11 @@ static const struct pci224_board
* This function looks for a PCI device matching the requested board name, * This function looks for a PCI device matching the requested board name,
* bus and slot. * bus and slot.
*/ */
static int static struct pci_dev *
pci224_find_pci(struct comedi_device *dev, int bus, int slot, pci224_find_pci(struct comedi_device *dev, int bus, int slot)
struct pci_dev **pci_dev_p)
{ {
struct pci_dev *pci_dev = NULL; struct pci_dev *pci_dev = NULL;
*pci_dev_p = NULL;
/* Look for matching PCI device. */ /* Look for matching PCI device. */
for (pci_dev = pci_get_device(PCI_VENDOR_ID_AMPLICON, PCI_ANY_ID, NULL); for (pci_dev = pci_get_device(PCI_VENDOR_ID_AMPLICON, PCI_ANY_ID, NULL);
pci_dev != NULL; pci_dev != NULL;
@ -1289,8 +1286,7 @@ pci224_find_pci(struct comedi_device *dev, int bus, int slot,
} }
/* Found a match. */ /* Found a match. */
*pci_dev_p = pci_dev; return pci_dev;
return 0;
} }
/* No match found. */ /* No match found. */
if (bus || slot) { if (bus || slot) {
@ -1301,7 +1297,7 @@ pci224_find_pci(struct comedi_device *dev, int bus, int slot,
dev_err(dev->class_dev, "error! no %s found!\n", dev_err(dev->class_dev, "error! no %s found!\n",
thisboard->name); thisboard->name);
} }
return -EIO; return NULL;
} }
static void pci224_report_attach(struct comedi_device *dev, unsigned int irq) static void pci224_report_attach(struct comedi_device *dev, unsigned int irq)
@ -1488,9 +1484,9 @@ static int pci224_attach(struct comedi_device *dev, struct comedi_devconfig *it)
return ret; return ret;
} }
ret = pci224_find_pci(dev, bus, slot, &pci_dev); pci_dev = pci224_find_pci(dev, bus, slot);
if (ret < 0) if (pci_dev == NULL)
return ret; return -EIO;
return pci224_attach_common(dev, pci_dev, it->options); return pci224_attach_common(dev, pci_dev, it->options);
} }