From 030f585c4e15013b84fdcbb5feb2777570a7923b Mon Sep 17 00:00:00 2001 From: Tom Marshall Date: Thu, 18 May 2017 23:50:22 +0000 Subject: [PATCH] kernel: Fix potential refcount leak in su check Change-Id: I8d2c8bed65a01eb0928308df638a04449a5bd881 --- fs/namei.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index 94e792fa5e6b..dbc6fe875db7 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2168,8 +2168,10 @@ static int path_lookupat(struct nameidata *nd, unsigned flags, struct path *path if (!err) { struct super_block *sb = nd->inode->i_sb; if (sb->s_flags & MS_RDONLY) { - if (d_is_su(nd->path.dentry) && !su_visible()) + if (d_is_su(nd->path.dentry) && !su_visible()) { + path_put(&nd->path); err = -ENOENT; + } } }