evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: s526: use comedi_timeout()

Browse source 
Use comedi_timeout() to wait for the analog input end-of-conversion.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2014-02-10 11:49:23 -07:00 • committed by Greg Kroah-Hartman
parent 3d21960b6d
commit 043fff873d
1 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
drivers/staging/comedi/drivers/s526.c
View file

@ -420,15 +420,28 @@ static int s526_ai_insn_config(struct comedi_device *dev,
return result; return result;
} }
static int s526_ai_eoc(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn,
unsigned long context)
{
unsigned int status;
status = inw(dev->iobase + REG_ISR);
if (status & ISR_ADC_DONE)
return 0;
return -EBUSY;
}
static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s, static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn, unsigned int *data)
{ {
struct s526_private *devpriv = dev->private; struct s526_private *devpriv = dev->private;
unsigned int chan = CR_CHAN(insn->chanspec); unsigned int chan = CR_CHAN(insn->chanspec);
int n, i; int n;
unsigned short value; unsigned short value;
unsigned int d; unsigned int d;
unsigned int status; int ret;
/* Set configured delay, enable channel for this channel only, /* Set configured delay, enable channel for this channel only,
* select "ADC read" channel, set "ADC start" bit. */ * select "ADC read" channel, set "ADC start" bit. */
@ -440,17 +453,12 @@ static int s526_ai_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
/* trigger conversion */ /* trigger conversion */
outw(value, dev->iobase + REG_ADC); outw(value, dev->iobase + REG_ADC);
#define TIMEOUT 100
/* wait for conversion to end */ /* wait for conversion to end */
for (i = 0; i < TIMEOUT; i++) { ret = comedi_timeout(dev, s, insn, s526_ai_eoc, 0);
status = inw(dev->iobase + REG_ISR); if (ret)
if (status & ISR_ADC_DONE) { return ret;
outw(ISR_ADC_DONE, dev->iobase + REG_ISR);
break; outw(ISR_ADC_DONE, dev->iobase + REG_ISR);
}
}
if (i == TIMEOUT)
return -ETIMEDOUT;
/* read data */ /* read data */
d = inw(dev->iobase + REG_ADD); d = inw(dev->iobase + REG_ADD);