From 07ab290b8a4948ea6607726e03f10691fd36c4e6 Mon Sep 17 00:00:00 2001 From: Manoj Prabhu B Date: Mon, 13 Jun 2016 12:52:48 +0530 Subject: [PATCH] diag: dci: Fix possible race condition during SSR This patch fixes the possible race condition because of the stray dci_mutex unlock statements. CRs-Fixed: 1027461 Change-Id: I10f3c6d1e2d3c6e71be04e3206273aad7971a6b5 Signed-off-by: Manoj Prabhu B --- drivers/char/diag/diag_dci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/diag/diag_dci.c b/drivers/char/diag/diag_dci.c index 1000b2595a83..b830334dc701 100644 --- a/drivers/char/diag/diag_dci.c +++ b/drivers/char/diag/diag_dci.c @@ -2964,7 +2964,6 @@ int diag_dci_deinit_client(struct diag_dci_client_tbl *entry) diag_update_userspace_clients(DCI_LOG_MASKS_TYPE); ret = dci_ops_tbl[token].send_log_mask(token); if (ret != DIAG_DCI_NO_ERROR) { - mutex_unlock(&driver->dci_mutex); return ret; } kfree(entry->dci_event_mask); @@ -2973,7 +2972,6 @@ int diag_dci_deinit_client(struct diag_dci_client_tbl *entry) diag_update_userspace_clients(DCI_EVENT_MASKS_TYPE); ret = dci_ops_tbl[token].send_event_mask(token); if (ret != DIAG_DCI_NO_ERROR) { - mutex_unlock(&driver->dci_mutex); return ret; }