evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

usb: gadget: printer: define pnp string buffer length

Browse source 
Avoid using magic numbers.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Andrzej Pietrasiewicz 2015-03-03 10:52:16 +01:00 • committed by Felipe Balbi
parent 991cd26249
commit 085617a1eb
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/usb/gadget/legacy/printer.c
View file

@ -276,9 +276,11 @@ static inline struct usb_endpoint_descriptor *ep_desc(struct usb_gadget *gadget,
/* descriptors that are built on-demand */ /* descriptors that are built on-demand */
#define PNP_STRING_LEN 1024
static char product_desc [40] = DRIVER_DESC; static char product_desc [40] = DRIVER_DESC;
static char serial_num [40] = "1"; static char serial_num [40] = "1";
static char pnp_string [1024] = static char pnp_string[PNP_STRING_LEN] =
"XXMFG:linux;MDL:g_printer;CLS:PRINTER;SN:1;"; "XXMFG:linux;MDL:g_printer;CLS:PRINTER;SN:1;";
/* static strings, in UTF-8 */ /* static strings, in UTF-8 */
@ -1247,7 +1249,7 @@ static int f_printer_bind_config(struct usb_configuration *c, char *pnp_str,
INIT_LIST_HEAD(&dev->rx_buffers); INIT_LIST_HEAD(&dev->rx_buffers);
if (pnp_str) if (pnp_str)
strlcpy(&pnp_string[2], pnp_str, sizeof(pnp_string) - 2); strlcpy(&pnp_string[2], pnp_str, PNP_STRING_LEN - 2);
len = strlen(pnp_string); len = strlen(pnp_string);
pnp_string[0] = (len >> 8) & 0xFF; pnp_string[0] = (len >> 8) & 0xFF;