evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

crypto: atmel - Free memory in error path

Browse source 
If only one of the 2 __get_free_pages fails, then there is a memory leak.

Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Christophe Jaillet 2015-01-20 08:15:52 +01:00 • committed by Herbert Xu
parent 379dcfb406
commit 088f628cc0
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/crypto/atmel-aes.c
View file

@ -673,9 +673,9 @@ err_map_out:
dma_unmap_single(dd->dev, dd->dma_addr_in, dd->buflen, dma_unmap_single(dd->dev, dd->dma_addr_in, dd->buflen,
DMA_TO_DEVICE); DMA_TO_DEVICE);
err_map_in: err_map_in:
err_alloc:
free_page((unsigned long)dd->buf_out); free_page((unsigned long)dd->buf_out);
free_page((unsigned long)dd->buf_in); free_page((unsigned long)dd->buf_in);
err_alloc:
if (err) if (err)
pr_err("error: %d\n", err); pr_err("error: %d\n", err);
return err; return err;

2
drivers/crypto/atmel-tdes.c
View file

@ -376,9 +376,9 @@ err_map_out:
dma_unmap_single(dd->dev, dd->dma_addr_in, dd->buflen, dma_unmap_single(dd->dev, dd->dma_addr_in, dd->buflen,
DMA_TO_DEVICE); DMA_TO_DEVICE);
err_map_in: err_map_in:
err_alloc:
free_page((unsigned long)dd->buf_out); free_page((unsigned long)dd->buf_out);
free_page((unsigned long)dd->buf_in); free_page((unsigned long)dd->buf_in);
err_alloc:
if (err) if (err)
pr_err("error: %d\n", err); pr_err("error: %d\n", err);
return err; return err;