evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

spmi: pmic-arb: replace symbolic permissions with constants

Browse source 
Change file permissions S_IRUSR and S_IWUSR to their octal
equivalents: 0400 and 0200 respectively.  This makes the code
easier to understand and avoids a checkpatch warning.

Change-Id: I00a8b81533367544e94a464fde8373fb5be544bd
Signed-off-by: David Collins <collinsd@codeaurora.org>
This commit is contained in:
David Collins 2017-01-13 17:37:31 -08:00
parent 7730bab8f2
commit 0ff5671bb2
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/spmi/spmi-pmic-arb.c
View file

@ -371,7 +371,7 @@ static int pmic_arb_read_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
if (rc) if (rc)
return rc; return rc;
if (!(mode & S_IRUSR)) { if (!(mode & 0400)) {
dev_err(&pa->spmic->dev, dev_err(&pa->spmic->dev,
"error: impermissible read from peripheral sid:%d addr:0x%x\n", "error: impermissible read from peripheral sid:%d addr:0x%x\n",
sid, addr); sid, addr);
@ -434,7 +434,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
if (rc) if (rc)
return rc; return rc;
if (!(mode & S_IWUSR)) { if (!(mode & 0200)) {
dev_err(&pa->spmic->dev, dev_err(&pa->spmic->dev,
"error: impermissible write to peripheral sid:%d addr:0x%x\n", "error: impermissible write to peripheral sid:%d addr:0x%x\n",
sid, addr); sid, addr);
@ -838,7 +838,7 @@ pmic_arb_ppid_to_apid_v1(struct spmi_pmic_arb *pa, u8 sid, u16 addr, u16 *apid)
static int static int
pmic_arb_mode_v1_v3(struct spmi_pmic_arb *pa, u8 sid, u16 addr, mode_t *mode) pmic_arb_mode_v1_v3(struct spmi_pmic_arb *pa, u8 sid, u16 addr, mode_t *mode)
{ {
*mode = S_IRUSR | S_IWUSR; *mode = 0600;
return 0; return 0;
} }
@ -998,10 +998,10 @@ pmic_arb_mode_v2(struct spmi_pmic_arb *pa, u8 sid, u16 addr, mode_t *mode)
return rc; return rc;
*mode = 0; *mode = 0;
*mode |= S_IRUSR; *mode |= 0400;
if (pa->ee == pa->apid_data[apid].write_owner) if (pa->ee == pa->apid_data[apid].write_owner)
*mode |= S_IWUSR; *mode |= 0200;
return 0; return 0;
} }