evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

msm: camera: Avoid uninitialized variables and add null checks

Browse source 
Initialize variables with default values and add null check to
avoid crashes.

Change-Id: I3357d504b624b0af2f0710ee237ec13d4460c6bc
Signed-off-by: Vijay kumar Tumati <vtumati@codeaurora.org>
This commit is contained in:
Vijay kumar Tumati 2016-04-01 17:03:43 +05:30 • committed by Kyle Yan
parent 4ccef09c65
commit 11eb50a115
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/media/platform/msm/camera_v2/sensor/eeprom/msm_eeprom.c
View file

@ -863,6 +863,11 @@ static int msm_eeprom_i2c_remove(struct i2c_client *client)
return 0; return 0;
} }
if (!e_ctrl->eboard_info) {
pr_err("%s: eboard_info is NULL\n", __func__);
return 0;
}
msm_camera_put_clk_info(e_ctrl->pdev, msm_camera_put_clk_info(e_ctrl->pdev,
&e_ctrl->eboard_info->power_info.clk_info, &e_ctrl->eboard_info->power_info.clk_info,
&e_ctrl->eboard_info->power_info.clk_ptr, &e_ctrl->eboard_info->power_info.clk_ptr,

2
drivers/media/platform/msm/camera_v2/sensor/io/msm_camera_qup_i2c.c
View file

@ -398,7 +398,7 @@ int32_t msm_camera_qup_i2c_poll(struct msm_camera_i2c_client *client,
uint32_t addr, uint16_t data, uint32_t addr, uint16_t data,
enum msm_camera_i2c_data_type data_type, uint32_t delay_ms) enum msm_camera_i2c_data_type data_type, uint32_t delay_ms)
{ {
int32_t rc; int32_t rc = 0;
int i; int i;
S_I2C_DBG("%s: addr: 0x%x data: 0x%x dt: %d\n", S_I2C_DBG("%s: addr: 0x%x data: 0x%x dt: %d\n",
__func__, addr, data, data_type); __func__, addr, data, data_type);