staging: comedi: ni_660x: rename the CamelCase enum NI_660x_Register and labels

As prefered by the CodingStyle, rename this CamelCase enum and its labels.

Also, cleanup the ni_gpct_to_660x_register() helper function. Just return the
ni_660x_register for each ni_gpct_register and remove the unnecessary break
statements after the return statements.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/ni_660x.c

@@ -55,112 +55,112 @@ for 4 */
 #define MAX_DMA_CHANNEL 4
 
 /* See Register-Level Programmer Manual page 3.1 */
-enum NI_660x_Register {
+enum ni_660x_register {
-	G0InterruptAcknowledge,
+	NI660X_G0_INT_ACK,
-	G0StatusRegister,
+	NI660X_G0_STATUS,
-	G1InterruptAcknowledge,
+	NI660X_G1_INT_ACK,
-	G1StatusRegister,
+	NI660X_G1_STATUS,
-	G01StatusRegister,
+	NI660X_G01_STATUS,
-	G0CommandRegister,
+	NI660X_G0_CMD,
-	STCDIOParallelInput,
+	NI660X_STC_DIO_PARALLEL_INPUT,
-	G1CommandRegister,
+	NI660X_G1_CMD,
-	G0HWSaveRegister,
+	NI660X_G0_HW_SAVE,
-	G1HWSaveRegister,
+	NI660X_G1_HW_SAVE,
-	STCDIOOutput,
+	NI660X_STC_DIO_OUTPUT,
-	STCDIOControl,
+	NI660X_STC_DIO_CONTROL,
-	G0SWSaveRegister,
+	NI660X_G0_SW_SAVE,
-	G1SWSaveRegister,
+	NI660X_G1_SW_SAVE,
-	G0ModeRegister,
+	NI660X_G0_MODE,
-	G01JointStatus1Register,
+	NI660X_G01_STATUS1,
-	G1ModeRegister,
+	NI660X_G1_MODE,
-	STCDIOSerialInput,
+	NI660X_STC_DIO_SERIAL_INPUT,
-	G0LoadARegister,
+	NI660X_G0_LOADA,
-	G01JointStatus2Register,
+	NI660X_G01_STATUS2,
-	G0LoadBRegister,
+	NI660X_G0_LOADB,
-	G1LoadARegister,
+	NI660X_G1_LOADA,
-	G1LoadBRegister,
+	NI660X_G1_LOADB,
-	G0InputSelectRegister,
+	NI660X_G0_INPUT_SEL,
-	G1InputSelectRegister,
+	NI660X_G1_INPUT_SEL,
-	G0AutoincrementRegister,
+	NI660X_G0_AUTO_INC,
-	G1AutoincrementRegister,
+	NI660X_G1_AUTO_INC,
-	G01JointResetRegister,
+	NI660X_G01_RESET,
-	G0InterruptEnable,
+	NI660X_G0_INT_ENA,
-	G1InterruptEnable,
+	NI660X_G1_INT_ENA,
-	G0CountingModeRegister,
+	NI660X_G0_CNT_MODE,
-	G1CountingModeRegister,
+	NI660X_G1_CNT_MODE,
-	G0SecondGateRegister,
+	NI660X_G0_GATE2,
-	G1SecondGateRegister,
+	NI660X_G1_GATE2,
-	G0DMAConfigRegister,
+	NI660X_G0_DMA_CFG,
-	G0DMAStatusRegister,
+	NI660X_G0_DMA_STATUS,
-	G1DMAConfigRegister,
+	NI660X_G1_DMA_CFG,
-	G1DMAStatusRegister,
+	NI660X_G1_DMA_STATUS,
-	G2InterruptAcknowledge,
+	NI660X_G2_INT_ACK,
-	G2StatusRegister,
+	NI660X_G2_STATUS,
-	G3InterruptAcknowledge,
+	NI660X_G3_INT_ACK,
-	G3StatusRegister,
+	NI660X_G3_STATUS,
-	G23StatusRegister,
+	NI660X_G23_STATUS,
-	G2CommandRegister,
+	NI660X_G2_CMD,
-	G3CommandRegister,
+	NI660X_G3_CMD,
-	G2HWSaveRegister,
+	NI660X_G2_HW_SAVE,
-	G3HWSaveRegister,
+	NI660X_G3_HW_SAVE,
-	G2SWSaveRegister,
+	NI660X_G2_SW_SAVE,
-	G3SWSaveRegister,
+	NI660X_G3_SW_SAVE,
-	G2ModeRegister,
+	NI660X_G2_MODE,
-	G23JointStatus1Register,
+	NI660X_G23_STATUS1,
-	G3ModeRegister,
+	NI660X_G3_MODE,
-	G2LoadARegister,
+	NI660X_G2_LOADA,
-	G23JointStatus2Register,
+	NI660X_G23_STATUS2,
-	G2LoadBRegister,
+	NI660X_G2_LOADB,
-	G3LoadARegister,
+	NI660X_G3_LOADA,
-	G3LoadBRegister,
+	NI660X_G3_LOADB,
-	G2InputSelectRegister,
+	NI660X_G2_INPUT_SEL,
-	G3InputSelectRegister,
+	NI660X_G3_INPUT_SEL,
-	G2AutoincrementRegister,
+	NI660X_G2_AUTO_INC,
-	G3AutoincrementRegister,
+	NI660X_G3_AUTO_INC,
-	G23JointResetRegister,
+	NI660X_G23_RESET,
-	G2InterruptEnable,
+	NI660X_G2_INT_ENA,
-	G3InterruptEnable,
+	NI660X_G3_INT_ENA,
-	G2CountingModeRegister,
+	NI660X_G2_CNT_MODE,
-	G3CountingModeRegister,
+	NI660X_G3_CNT_MODE,
-	G3SecondGateRegister,
+	NI660X_G3_GATE2,
-	G2SecondGateRegister,
+	NI660X_G2_GATE2,
-	G2DMAConfigRegister,
+	NI660X_G2_DMA_CFG,
-	G2DMAStatusRegister,
+	NI660X_G2_DMA_STATUS,
-	G3DMAConfigRegister,
+	NI660X_G3_DMA_CFG,
-	G3DMAStatusRegister,
+	NI660X_G3_DMA_STATUS,
-	DIO32Input,
+	NI660X_DIO32_INPUT,
-	DIO32Output,
+	NI660X_DIO32_OUTPUT,
-	ClockConfigRegister,
+	NI660X_CLK_CFG,
-	GlobalInterruptStatusRegister,
+	NI660X_GLOBAL_INT_STATUS,
-	DMAConfigRegister,
+	NI660X_DMA_CFG,
-	GlobalInterruptConfigRegister,
+	NI660X_GLOBAL_INT_CFG,
-	IOConfigReg0_1,
+	NI660X_IO_CFG_0_1,
-	IOConfigReg2_3,
+	NI660X_IO_CFG_2_3,
-	IOConfigReg4_5,
+	NI660X_IO_CFG_4_5,
-	IOConfigReg6_7,
+	NI660X_IO_CFG_6_7,
-	IOConfigReg8_9,
+	NI660X_IO_CFG_8_9,
-	IOConfigReg10_11,
+	NI660X_IO_CFG_10_11,
-	IOConfigReg12_13,
+	NI660X_IO_CFG_12_13,
-	IOConfigReg14_15,
+	NI660X_IO_CFG_14_15,
-	IOConfigReg16_17,
+	NI660X_IO_CFG_16_17,
-	IOConfigReg18_19,
+	NI660X_IO_CFG_18_19,
-	IOConfigReg20_21,
+	NI660X_IO_CFG_20_21,
-	IOConfigReg22_23,
+	NI660X_IO_CFG_22_23,
-	IOConfigReg24_25,
+	NI660X_IO_CFG_24_25,
-	IOConfigReg26_27,
+	NI660X_IO_CFG_26_27,
-	IOConfigReg28_29,
+	NI660X_IO_CFG_28_29,
-	IOConfigReg30_31,
+	NI660X_IO_CFG_30_31,
-	IOConfigReg32_33,
+	NI660X_IO_CFG_32_33,
-	IOConfigReg34_35,
+	NI660X_IO_CFG_34_35,
-	IOConfigReg36_37,
+	NI660X_IO_CFG_36_37,
-	IOConfigReg38_39,
+	NI660X_IO_CFG_38_39,
-	NumRegisters,
+	NI660X_NUM_REGS,
 };
 
 static inline unsigned IOConfigReg(unsigned pfi_channel)
 {
-	unsigned reg = IOConfigReg0_1 + pfi_channel / 2;
+	unsigned reg = NI660X_IO_CFG_0_1 + pfi_channel / 2;
-	BUG_ON(reg > IOConfigReg38_39);
+	BUG_ON(reg > NI660X_IO_CFG_38_39);
 	return reg;
 }
 
@@ -200,7 +200,7 @@ struct NI_660xRegisterData {
 	enum ni_660x_register_width size; /* 1 byte, 2 bytes, or 4 bytes */
 };
 
-static const struct NI_660xRegisterData registerData[NumRegisters] = {
+static const struct NI_660xRegisterData registerData[NI660X_NUM_REGS] = {
 	{"G0 Interrupt Acknowledge", 0x004, NI_660x_WRITE, DATA_2B},
 	{"G0 Status Register", 0x004, NI_660x_READ, DATA_2B},
 	{"G1 Interrupt Acknowledge", 0x006, NI_660x_WRITE, DATA_2B},
@@ -444,225 +444,154 @@ static inline unsigned ni_660x_num_counters(struct comedi_device *dev)
 	return board->n_chips * counters_per_chip;
 }
 
-static enum NI_660x_Register ni_gpct_to_660x_register(enum ni_gpct_register reg)
+static enum ni_660x_register ni_gpct_to_660x_register(enum ni_gpct_register reg)
 {
-	enum NI_660x_Register ni_660x_register;
 	switch (reg) {
 	case NITIO_G0_AUTO_INC:
-		ni_660x_register = G0AutoincrementRegister;
+		return NI660X_G0_AUTO_INC;
-		break;
 	case NITIO_G1_AUTO_INC:
-		ni_660x_register = G1AutoincrementRegister;
+		return NI660X_G1_AUTO_INC;
-		break;
 	case NITIO_G2_AUTO_INC:
-		ni_660x_register = G2AutoincrementRegister;
+		return NI660X_G2_AUTO_INC;
-		break;
 	case NITIO_G3_AUTO_INC:
-		ni_660x_register = G3AutoincrementRegister;
+		return NI660X_G3_AUTO_INC;
-		break;
 	case NITIO_G0_CMD:
-		ni_660x_register = G0CommandRegister;
+		return NI660X_G0_CMD;
-		break;
 	case NITIO_G1_CMD:
-		ni_660x_register = G1CommandRegister;
+		return NI660X_G1_CMD;
-		break;
 	case NITIO_G2_CMD:
-		ni_660x_register = G2CommandRegister;
+		return NI660X_G2_CMD;
-		break;
 	case NITIO_G3_CMD:
-		ni_660x_register = G3CommandRegister;
+		return NI660X_G3_CMD;
-		break;
 	case NITIO_G0_HW_SAVE:
-		ni_660x_register = G0HWSaveRegister;
+		return NI660X_G0_HW_SAVE;
-		break;
 	case NITIO_G1_HW_SAVE:
-		ni_660x_register = G1HWSaveRegister;
+		return NI660X_G1_HW_SAVE;
-		break;
 	case NITIO_G2_HW_SAVE:
-		ni_660x_register = G2HWSaveRegister;
+		return NI660X_G2_HW_SAVE;
-		break;
 	case NITIO_G3_HW_SAVE:
-		ni_660x_register = G3HWSaveRegister;
+		return NI660X_G3_HW_SAVE;
-		break;
 	case NITIO_G0_SW_SAVE:
-		ni_660x_register = G0SWSaveRegister;
+		return NI660X_G0_SW_SAVE;
-		break;
 	case NITIO_G1_SW_SAVE:
-		ni_660x_register = G1SWSaveRegister;
+		return NI660X_G1_SW_SAVE;
-		break;
 	case NITIO_G2_SW_SAVE:
-		ni_660x_register = G2SWSaveRegister;
+		return NI660X_G2_SW_SAVE;
-		break;
 	case NITIO_G3_SW_SAVE:
-		ni_660x_register = G3SWSaveRegister;
+		return NI660X_G3_SW_SAVE;
-		break;
 	case NITIO_G0_MODE:
-		ni_660x_register = G0ModeRegister;
+		return NI660X_G0_MODE;
-		break;
 	case NITIO_G1_MODE:
-		ni_660x_register = G1ModeRegister;
+		return NI660X_G1_MODE;
-		break;
 	case NITIO_G2_MODE:
-		ni_660x_register = G2ModeRegister;
+		return NI660X_G2_MODE;
-		break;
 	case NITIO_G3_MODE:
-		ni_660x_register = G3ModeRegister;
+		return NI660X_G3_MODE;
-		break;
 	case NITIO_G0_LOADA:
-		ni_660x_register = G0LoadARegister;
+		return NI660X_G0_LOADA;
-		break;
 	case NITIO_G1_LOADA:
-		ni_660x_register = G1LoadARegister;
+		return NI660X_G1_LOADA;
-		break;
 	case NITIO_G2_LOADA:
-		ni_660x_register = G2LoadARegister;
+		return NI660X_G2_LOADA;
-		break;
 	case NITIO_G3_LOADA:
-		ni_660x_register = G3LoadARegister;
+		return NI660X_G3_LOADA;
-		break;
 	case NITIO_G0_LOADB:
-		ni_660x_register = G0LoadBRegister;
+		return NI660X_G0_LOADB;
-		break;
 	case NITIO_G1_LOADB:
-		ni_660x_register = G1LoadBRegister;
+		return NI660X_G1_LOADB;
-		break;
 	case NITIO_G2_LOADB:
-		ni_660x_register = G2LoadBRegister;
+		return NI660X_G2_LOADB;
-		break;
 	case NITIO_G3_LOADB:
-		ni_660x_register = G3LoadBRegister;
+		return NI660X_G3_LOADB;
-		break;
 	case NITIO_G0_INPUT_SEL:
-		ni_660x_register = G0InputSelectRegister;
+		return NI660X_G0_INPUT_SEL;
-		break;
 	case NITIO_G1_INPUT_SEL:
-		ni_660x_register = G1InputSelectRegister;
+		return NI660X_G1_INPUT_SEL;
-		break;
 	case NITIO_G2_INPUT_SEL:
-		ni_660x_register = G2InputSelectRegister;
+		return NI660X_G2_INPUT_SEL;
-		break;
 	case NITIO_G3_INPUT_SEL:
-		ni_660x_register = G3InputSelectRegister;
+		return NI660X_G3_INPUT_SEL;
-		break;
 	case NITIO_G01_STATUS:
-		ni_660x_register = G01StatusRegister;
+		return NI660X_G01_STATUS;
-		break;
 	case NITIO_G23_STATUS:
-		ni_660x_register = G23StatusRegister;
+		return NI660X_G23_STATUS;
-		break;
 	case NITIO_G01_RESET:
-		ni_660x_register = G01JointResetRegister;
+		return NI660X_G01_RESET;
-		break;
 	case NITIO_G23_RESET:
-		ni_660x_register = G23JointResetRegister;
+		return NI660X_G23_RESET;
-		break;
 	case NITIO_G01_STATUS1:
-		ni_660x_register = G01JointStatus1Register;
+		return NI660X_G01_STATUS1;
-		break;
 	case NITIO_G23_STATUS1:
-		ni_660x_register = G23JointStatus1Register;
+		return NI660X_G23_STATUS1;
-		break;
 	case NITIO_G01_STATUS2:
-		ni_660x_register = G01JointStatus2Register;
+		return NI660X_G01_STATUS2;
-		break;
 	case NITIO_G23_STATUS2:
-		ni_660x_register = G23JointStatus2Register;
+		return NI660X_G23_STATUS2;
-		break;
 	case NITIO_G0_CNT_MODE:
-		ni_660x_register = G0CountingModeRegister;
+		return NI660X_G0_CNT_MODE;
-		break;
 	case NITIO_G1_CNT_MODE:
-		ni_660x_register = G1CountingModeRegister;
+		return NI660X_G1_CNT_MODE;
-		break;
 	case NITIO_G2_CNT_MODE:
-		ni_660x_register = G2CountingModeRegister;
+		return NI660X_G2_CNT_MODE;
-		break;
 	case NITIO_G3_CNT_MODE:
-		ni_660x_register = G3CountingModeRegister;
+		return NI660X_G3_CNT_MODE;
-		break;
 	case NITIO_G0_GATE2:
-		ni_660x_register = G0SecondGateRegister;
+		return NI660X_G0_GATE2;
-		break;
 	case NITIO_G1_GATE2:
-		ni_660x_register = G1SecondGateRegister;
+		return NI660X_G1_GATE2;
-		break;
 	case NITIO_G2_GATE2:
-		ni_660x_register = G2SecondGateRegister;
+		return NI660X_G2_GATE2;
-		break;
 	case NITIO_G3_GATE2:
-		ni_660x_register = G3SecondGateRegister;
+		return NI660X_G3_GATE2;
-		break;
 	case NITIO_G0_DMA_CFG:
-		ni_660x_register = G0DMAConfigRegister;
+		return NI660X_G0_DMA_CFG;
-		break;
 	case NITIO_G0_DMA_STATUS:
-		ni_660x_register = G0DMAStatusRegister;
+		return NI660X_G0_DMA_STATUS;
-		break;
 	case NITIO_G1_DMA_CFG:
-		ni_660x_register = G1DMAConfigRegister;
+		return NI660X_G1_DMA_CFG;
-		break;
 	case NITIO_G1_DMA_STATUS:
-		ni_660x_register = G1DMAStatusRegister;
+		return NI660X_G1_DMA_STATUS;
-		break;
 	case NITIO_G2_DMA_CFG:
-		ni_660x_register = G2DMAConfigRegister;
+		return NI660X_G2_DMA_CFG;
-		break;
 	case NITIO_G2_DMA_STATUS:
-		ni_660x_register = G2DMAStatusRegister;
+		return NI660X_G2_DMA_STATUS;
-		break;
 	case NITIO_G3_DMA_CFG:
-		ni_660x_register = G3DMAConfigRegister;
+		return NI660X_G3_DMA_CFG;
-		break;
 	case NITIO_G3_DMA_STATUS:
-		ni_660x_register = G3DMAStatusRegister;
+		return NI660X_G3_DMA_STATUS;
-		break;
 	case NITIO_G0_INT_ACK:
-		ni_660x_register = G0InterruptAcknowledge;
+		return NI660X_G0_INT_ACK;
-		break;
 	case NITIO_G1_INT_ACK:
-		ni_660x_register = G1InterruptAcknowledge;
+		return NI660X_G1_INT_ACK;
-		break;
 	case NITIO_G2_INT_ACK:
-		ni_660x_register = G2InterruptAcknowledge;
+		return NI660X_G2_INT_ACK;
-		break;
 	case NITIO_G3_INT_ACK:
-		ni_660x_register = G3InterruptAcknowledge;
+		return NI660X_G3_INT_ACK;
-		break;
 	case NITIO_G0_STATUS:
-		ni_660x_register = G0StatusRegister;
+		return NI660X_G0_STATUS;
-		break;
 	case NITIO_G1_STATUS:
-		ni_660x_register = G1StatusRegister;
+		return NI660X_G1_STATUS;
-		break;
 	case NITIO_G2_STATUS:
-		ni_660x_register = G2StatusRegister;
+		return NI660X_G2_STATUS;
-		break;
 	case NITIO_G3_STATUS:
-		ni_660x_register = G3StatusRegister;
+		return NI660X_G3_STATUS;
-		break;
 	case NITIO_G0_INT_ENA:
-		ni_660x_register = G0InterruptEnable;
+		return NI660X_G0_INT_ENA;
-		break;
 	case NITIO_G1_INT_ENA:
-		ni_660x_register = G1InterruptEnable;
+		return NI660X_G1_INT_ENA;
-		break;
 	case NITIO_G2_INT_ENA:
-		ni_660x_register = G2InterruptEnable;
+		return NI660X_G2_INT_ENA;
-		break;
 	case NITIO_G3_INT_ENA:
-		ni_660x_register = G3InterruptEnable;
+		return NI660X_G3_INT_ENA;
-		break;
 	default:
 		BUG();
 		return 0;
-		break;
 	}
-	return ni_660x_register;
 }
 
 static inline void ni_660x_write_register(struct comedi_device *dev,
 					  unsigned chip_index, unsigned bits,
-					  enum NI_660x_Register reg)
+					  enum ni_660x_register reg)
 {
 	struct ni_660x_private *devpriv = dev->private;
 	void __iomem *write_address =
@@ -684,7 +613,7 @@ static inline void ni_660x_write_register(struct comedi_device *dev,
 
 static inline unsigned ni_660x_read_register(struct comedi_device *dev,
 					     unsigned chip_index,
-					     enum NI_660x_Register reg)
+					     enum ni_660x_register reg)
 {
 	struct ni_660x_private *devpriv = dev->private;
 	void __iomem *read_address =
@@ -709,7 +638,7 @@ static void ni_gpct_write_register(struct ni_gpct *counter, unsigned bits,
 				   enum ni_gpct_register reg)
 {
 	struct comedi_device *dev = counter->counter_dev->dev;
-	enum NI_660x_Register ni_660x_register = ni_gpct_to_660x_register(reg);
+	enum ni_660x_register ni_660x_register = ni_gpct_to_660x_register(reg);
 	ni_660x_write_register(dev, counter->chip_index, bits,
 			       ni_660x_register);
 }
@@ -718,7 +647,7 @@ static unsigned ni_gpct_read_register(struct ni_gpct *counter,
 				      enum ni_gpct_register reg)
 {
 	struct comedi_device *dev = counter->counter_dev->dev;
-	enum NI_660x_Register ni_660x_register = ni_gpct_to_660x_register(reg);
+	enum ni_660x_register ni_660x_register = ni_gpct_to_660x_register(reg);
 	return ni_660x_read_register(dev, counter->chip_index,
 				     ni_660x_register);
 }
@@ -747,7 +676,7 @@ static inline void ni_660x_set_dma_channel(struct comedi_device *dev,
 	ni_660x_write_register(dev, counter->chip_index,
 			       devpriv->dma_configuration_soft_copies
 			       [counter->chip_index] |
-			       dma_reset_bit(mite_channel), DMAConfigRegister);
+			       dma_reset_bit(mite_channel), NI660X_DMA_CFG);
 	mmiowb();
 	spin_unlock_irqrestore(&devpriv->soft_reg_copy_lock, flags);
 }
@@ -766,7 +695,7 @@ static inline void ni_660x_unset_dma_channel(struct comedi_device *dev,
 	    dma_select_bits(mite_channel, dma_selection_none);
 	ni_660x_write_register(dev, counter->chip_index,
 			       devpriv->dma_configuration_soft_copies
-			       [counter->chip_index], DMAConfigRegister);
+			       [counter->chip_index], NI660X_DMA_CFG);
 	mmiowb();
 	spin_unlock_irqrestore(&devpriv->soft_reg_copy_lock, flags);
 }
@@ -847,9 +776,9 @@ static void set_tio_counterswap(struct comedi_device *dev, int chipset)
 	 */
 	if (chipset)
 		ni_660x_write_register(dev, chipset, CounterSwap,
-				       ClockConfigRegister);
+				       NI660X_CLK_CFG);
 	else
-		ni_660x_write_register(dev, chipset, 0, ClockConfigRegister);
+		ni_660x_write_register(dev, chipset, 0, NI660X_CLK_CFG);
 }
 
 static void ni_660x_handle_gpct_interrupt(struct comedi_device *dev,
@@ -979,7 +908,7 @@ static void init_tio_chip(struct comedi_device *dev, int chipset)
 	}
 	ni_660x_write_register(dev, chipset,
 			       devpriv->dma_configuration_soft_copies[chipset],
-			       DMAConfigRegister);
+			       NI660X_DMA_CFG);
 	for (i = 0; i < NUM_PFI_CHANNELS; ++i)
 		ni_660x_write_register(dev, chipset, 0, IOConfigReg(i));
 }
@@ -995,13 +924,13 @@ static int ni_660x_dio_insn_bits(struct comedi_device *dev,
 		s->state &= ~(data[0] << base_bitfield_channel);
 		s->state |= (data[0] & data[1]) << base_bitfield_channel;
 		/* Write out the new digital output lines */
-		ni_660x_write_register(dev, 0, s->state, DIO32Output);
+		ni_660x_write_register(dev, 0, s->state, NI660X_DIO32_OUTPUT);
 	}
 	/* on return, data[1] contains the value of the digital
 	 * input and output lines. */
-	data[1] =
+	data[1] = (ni_660x_read_register(dev, 0, NI660X_DIO32_INPUT) >>
-	    (ni_660x_read_register(dev, 0,
+			base_bitfield_channel);
-				   DIO32Input) >> base_bitfield_channel);
+
 	return insn->n;
 }
 
@@ -1186,7 +1115,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
 	s->insn_config = ni_660x_dio_insn_config;
 	/*  we use the ioconfig registers to control dio direction, so zero
 	output enables in stc dio control reg */
-	ni_660x_write_register(dev, 0, 0, STCDIOControl);
+	ni_660x_write_register(dev, 0, 0, NI660X_STC_DIO_CONTROL);
 
 	devpriv->counter_dev = ni_gpct_device_construct(dev,
 						     &ni_gpct_write_register,
@@ -1255,7 +1184,7 @@ static int ni_660x_auto_attach(struct comedi_device *dev,
 	if (board->n_chips > 1)
 		global_interrupt_config_bits |= Cascade_Int_Enable_Bit;
 	ni_660x_write_register(dev, 0, global_interrupt_config_bits,
-			       GlobalInterruptConfigRegister);
+			       NI660X_GLOBAL_INT_CFG);
 	dev_info(dev->class_dev, "ni_660x: %s attached\n", dev->board_name);
 	return 0;
 }