evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc: ti: knav_qmss_queue: Use list_for_each_entry_safe to prevent use after free

Browse source 
list_for_each_entry_safe() is necessary if list objects are deleted from
the list while traversing it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
This commit is contained in:
Axel Lin 2014-11-03 10:21:54 -08:00 • committed by Santosh Shilimkar
parent 39179cb5b7
commit 148bb0439a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/soc/ti/knav_qmss_queue.c
View file

@ -1306,14 +1306,14 @@ static void knav_free_queue_ranges(struct knav_device *kdev)
static void knav_queue_free_regions(struct knav_device *kdev) static void knav_queue_free_regions(struct knav_device *kdev)
{ {
struct knav_region *region; struct knav_region *region;
struct knav_pool *pool; struct knav_pool *pool, *tmp;
unsigned size; unsigned size;
for (;;) { for (;;) {
region = first_region(kdev); region = first_region(kdev);
if (!region) if (!region)
break; break;
list_for_each_entry(pool, &region->pools, region_inst) list_for_each_entry_safe(pool, tmp, &region->pools, region_inst)
knav_pool_destroy(pool); knav_pool_destroy(pool);
size = region->virt_end - region->virt_start; size = region->virt_end - region->virt_start;