evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

regulator: cpr3-regulator: fix potential aging uninitialized variable usage

Browse source 
If cpr3_ctrl_clear_cpr4_config() returns an error at the
beginning of the cpr3_regulator_measure_aging() function, then
goto cleanup is called.  After that, the *_restore values are
written back into hardware registers.  Unfortunately, these
*_restore variables are uninitialized in this code path.
Correct this issue.

Change-Id: I906613a00137925c9903ac6c01771c459594864f
CRs-Fixed: 1066407
Signed-off-by: David Collins <collinsd@codeaurora.org>
This commit is contained in:
David Collins 2016-09-13 11:47:23 -07:00
parent 9c8924dbaa
commit 14d435eaf2
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/regulator/cpr3-regulator.c
View file

@ -3362,7 +3362,8 @@ static int cpr3_regulator_measure_aging(struct cpr3_controller *ctrl,
if (rc) {
cpr3_err(ctrl, "failed to clear CPR4 configuration,rc=%d\n",
rc);
goto cleanup;
kfree(quot_delta_results);
return rc;
}
}