evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: sctp: sctp_outq: remove 'malloced' from its struct

Browse source 
sctp_outq is embedded into sctp_association, and thus never
kmalloced in any way. Also, malloced is always 0, thus kfree()
is never called. Therefore, remove that dead piece of code.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Daniel Borkmann 2013-04-16 11:07:12 +00:00 • committed by David S. Miller
parent ee16371e6c
commit 165a4c3127
2 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
include/net/sctp/structs.h
View file

@ -1059,9 +1059,6 @@ struct sctp_outq {
/* Is this structure empty? */ /* Is this structure empty? */
char empty; char empty;
/* Are we kfree()able? */
char malloced;
}; };
void sctp_outq_init(struct sctp_association *, struct sctp_outq *); void sctp_outq_init(struct sctp_association *, struct sctp_outq *);

6
net/sctp/outqueue.c
View file

@ -217,8 +217,6 @@ void sctp_outq_init(struct sctp_association *asoc, struct sctp_outq *q)
q->outstanding_bytes = 0; q->outstanding_bytes = 0;
q->empty = 1; q->empty = 1;
q->cork = 0; q->cork = 0;
q->malloced = 0;
q->out_qlen = 0; q->out_qlen = 0;
} }
@ -295,10 +293,6 @@ void sctp_outq_free(struct sctp_outq *q)
{ {
/* Throw away leftover chunks. */ /* Throw away leftover chunks. */
__sctp_outq_teardown(q); __sctp_outq_teardown(q);
/* If we were kmalloc()'d, free the memory. */
if (q->malloced)
kfree(q);
} }
/* Put a new chunk in an sctp_outq. */ /* Put a new chunk in an sctp_outq. */