evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] EM28xx - Fix memory leak on disconnect or error

Browse source 
Release the dev->alt_max_pkt_size buffer in all cases.

Signed-off-by: Chris Rankin <rankincj@yahoo.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Chris Rankin 2011-09-04 15:38:14 -03:00 • committed by Mauro Carvalho Chehab
parent 7577911244
commit 16e3d2f4fa
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/media/video/em28xx/em28xx-cards.c
View file

@ -3201,6 +3201,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
retval = em28xx_init_dev(&dev, udev, interface, nr); retval = em28xx_init_dev(&dev, udev, interface, nr);
if (retval) { if (retval) {
mutex_unlock(&dev->lock); mutex_unlock(&dev->lock);
kfree(dev->alt_max_pkt_size);
kfree(dev); kfree(dev);
goto err; goto err;
} }

1
drivers/media/video/em28xx/em28xx-video.c
View file

@ -2200,6 +2200,7 @@ static int em28xx_v4l2_close(struct file *filp)
free the remaining resources */ free the remaining resources */
if (dev->state & DEV_DISCONNECTED) { if (dev->state & DEV_DISCONNECTED) {
em28xx_release_resources(dev); em28xx_release_resources(dev);
kfree(dev->alt_max_pkt_size);
kfree(dev); kfree(dev);
return 0; return 0;
} }