evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

spmi: pmic-arb: Return an error code if sanity check fails

Browse source 
If the test 'if (channel > 5)' is true, then we will return 'err' which
is known to be 0 at this point.
Return -EINVAL instead.

Change-Id: I4f558ffb9cde0c9c1127202cd8b5d3ff11987c86
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Git-commit: e98cc182a06af3b8e91d6d719708db07045d78c4
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Signed-off-by: David Collins <collinsd@codeaurora.org>
This commit is contained in:
Christophe JAILLET 2016-09-26 22:24:46 +02:00 • committed by David Collins
parent 0ff5671bb2
commit 1739f5d376
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/spmi/spmi-pmic-arb.c
View file

@ -1320,6 +1320,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
if (channel > 5) { if (channel > 5) {
dev_err(&pdev->dev, "invalid channel (%u) specified.\n", dev_err(&pdev->dev, "invalid channel (%u) specified.\n",
channel); channel);
err = -EINVAL;
goto err_put_ctrl; goto err_put_ctrl;
} }