evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NFSv4: Fix a bug in __nfs4_find_state_byowner

Browse source 
The test for state->state == 0 does not tell you that the stateid is in the
process of being freed. It really tells you that the stateid is not yet
initialised...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Trond Myklebust 2007-07-03 14:41:19 -04:00
parent 1b45c46cf7
commit 1c816efa24
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
fs/nfs/nfs4state.c
View file

@ -333,14 +333,11 @@ __nfs4_find_state_byowner(struct inode *inode, struct nfs4_state_owner *owner)
struct nfs4_state *state; struct nfs4_state *state;
list_for_each_entry(state, &nfsi->open_states, inode_states) { list_for_each_entry(state, &nfsi->open_states, inode_states) {
/* Is this in the process of being freed? */ if (state->owner != owner)
if (state->state == 0)
continue; continue;
if (state->owner == owner) { if (atomic_inc_not_zero(&state->count))
atomic_inc(&state->count);
return state; return state;
} }
}
return NULL; return NULL;
} }