From 1d36d1fe947e29c347b6e84261d7b0837435c5fa Mon Sep 17 00:00:00 2001 From: Vikram Panduranga Date: Fri, 16 Sep 2016 16:49:55 -0700 Subject: [PATCH] drivers: soc: Initialize return var to default value Initialize return variable to default invalid handle before it is used. During an error condition it sets correct error code to avoid returning uninitialized return value. Change-Id: Ibad70b1bb364b60439c4988e318105a733396db8 Signed-off-by: Vikram Panduranga CRs-Fixed: 1059495 --- drivers/soc/qcom/qdsp6v2/apr_tal_glink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/qdsp6v2/apr_tal_glink.c b/drivers/soc/qcom/qdsp6v2/apr_tal_glink.c index dfd6b448a65f..e8969a5e533b 100644 --- a/drivers/soc/qcom/qdsp6v2/apr_tal_glink.c +++ b/drivers/soc/qcom/qdsp6v2/apr_tal_glink.c @@ -324,6 +324,7 @@ struct apr_svc_ch_dev *apr_tal_open(uint32_t clnt, uint32_t dest, uint32_t dl, pr_err("%s: glink_open failed %s\n", __func__, svc_names[dest][clnt]); apr_ch->handle = NULL; + rc = -EINVAL; goto unlock; }