evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bna: Semaphore Lock Fix

Browse source 
Remove a BUG_ON() as it is not required.

Change the unconditional write to release a semaphore to read sem first
and then write. This will eliminate the possibility of sem getting locked
while trying to release it in case if previous sem_get operation failed.

Signed-off-by: Gurunatha Karaje <gkaraje@brocade.com>
Signed-off-by: Rasesh Mody <rmody@brocade.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Rasesh Mody 2011-09-16 15:06:46 +00:00 • committed by David S. Miller
parent ae0e148934
commit 1d51a1325e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/brocade/bna/bfa_ioc.c
View file

@ -1201,13 +1201,13 @@ bfa_nw_ioc_sem_get(void __iomem *sem_reg)
if (!(r32 & 1)) if (!(r32 & 1))
return true; return true;
BUG_ON(!(cnt < BFA_SEM_SPINCNT));
return false; return false;
} }
void void
bfa_nw_ioc_sem_release(void __iomem *sem_reg) bfa_nw_ioc_sem_release(void __iomem *sem_reg)
{ {
readl(sem_reg);
writel(1, sem_reg); writel(1, sem_reg);
} }