evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: pcl818: remove unnecessary 'dev->irq' tests

Browse source 
These functions can only be called if the irq was sucessfully requested.
The dev->irq will always be valid.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-12-03 12:07:16 -07:00 • committed by Greg Kroah-Hartman
parent 35a8735d1c
commit 1dcea26a22
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/staging/comedi/drivers/pcl818.c
View file

@ -700,7 +700,7 @@ static irqreturn_t interrupt_pcl818(int irq, void *d)
outb(0, dev->iobase + PCL818_CLRINT); /* clear INT request */ outb(0, dev->iobase + PCL818_CLRINT); /* clear INT request */
if (!dev->irq || !devpriv->irq_blocked || !devpriv->ai_mode) { if (!devpriv->irq_blocked || !devpriv->ai_mode) {
comedi_error(dev, "bad IRQ!"); comedi_error(dev, "bad IRQ!");
return IRQ_NONE; return IRQ_NONE;
} }
@ -762,10 +762,6 @@ static int pcl818_ai_cmd_mode(int mode, struct comedi_device *dev,
unsigned int seglen; unsigned int seglen;
dev_dbg(dev->class_dev, "pcl818_ai_cmd_mode()\n"); dev_dbg(dev->class_dev, "pcl818_ai_cmd_mode()\n");
if (!dev->irq) {
comedi_error(dev, "IRQ not defined!");
return -EINVAL;
}
if (devpriv->irq_blocked) if (devpriv->irq_blocked)
return -EBUSY; return -EBUSY;