evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dm: remove pointless kobject comparison in dm_get_from_kobject

Browse source 
The comparison is always true and the compiler optimizes it out anyway.

Milan offered additional context relative to the original commit
784aae735d ("dm: add name and uuid to sysfs") which introduced the code:
"I think it is just relict of some experiments before I committed this
simple embedded sysfs kobj handling".

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Acked-by: Milan Broz <gmazyland@gmail.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Mikulas Patocka 2014-01-06 22:53:28 -05:00 • committed by Mike Snitzer
parent c1a6416021
commit 1ddd641ddc
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/md/dm.c
View file

@ -2905,17 +2905,11 @@ struct kobject *dm_kobject(struct mapped_device *md)
return &md->kobj; return &md->kobj;
} }
/*
* struct mapped_device should not be exported outside of dm.c
* so use this check to verify that kobj is part of md structure
*/
struct mapped_device *dm_get_from_kobject(struct kobject *kobj) struct mapped_device *dm_get_from_kobject(struct kobject *kobj)
{ {
struct mapped_device *md; struct mapped_device *md;
md = container_of(kobj, struct mapped_device, kobj); md = container_of(kobj, struct mapped_device, kobj);
if (&md->kobj != kobj)
return NULL;
if (test_bit(DMF_FREEING, &md->flags) || if (test_bit(DMF_FREEING, &md->flags) ||
dm_deleting_md(md)) dm_deleting_md(md))