evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: usbduxsigma: remove tidy_up() from (*auto_attach)

Browse source 
Comedi drivers do not need to cleanup allocations during the
(*auto_attach). If the (*auto_attach) fails the (*detach) will
automatically be called to handle the cleanup.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-05-23 12:55:28 -07:00 • committed by Greg Kroah-Hartman
parent 9838f532dc
commit 1fc56e86e4
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/comedi/drivers/usbduxsigma.c
View file

@ -1834,10 +1834,8 @@ static int usbduxsigma_auto_attach(struct comedi_device *dev,
} }
ret = usbduxsigma_alloc_usb_buffers(dev); ret = usbduxsigma_alloc_usb_buffers(dev);
if (ret) { if (ret)
tidy_up(devpriv);
return ret; return ret;
}
ret = comedi_load_firmware(dev, &usb->dev, FIRMWARE, ret = comedi_load_firmware(dev, &usb->dev, FIRMWARE,
usbduxsigma_firmware_upload, 0); usbduxsigma_firmware_upload, 0);