evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pwm-qpnp: fix the uninitialized pwm mode issue

Browse source 
If the led request the PWM mode and the initial mode is PWM
when change the led pwm mode, it will fail to change pwm mode
for no mode change with a uninitialized return code and cause
the LED configuration failing

Change-Id: I29ba3823fb7b4f0d1b2a0d9f22c464c94fbe9717
Signed-off-by: yanyh2 <yanyh2@lenovo.com>
Reviewed-on: https://gerrit.mot.com/1072946
SME-Granted: SME Approvals Granted
SLTApproved: Slta Waiver
Tested-by: Jira Key
Reviewed-by: Yeqing Wang <wangyq13@motorola.com>
Reviewed-by: Coverity Analysis <coverity@motorola.com>
Reviewed-by: Kenneth Kessler <kennykessler@motorola.com>
Submit-Approved: Jira Key
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
This commit is contained in:
yanyh2 2017-10-12 12:51:56 +08:00 • committed by Timi
parent c3b7b440aa
commit 20e091c857
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/pwm/pwm-qpnp.c
View file

@ -2230,8 +2230,10 @@ static int qpnp_parse_dt_config(struct platform_device *pdev,
} }
rc = of_property_read_u32(of_node, "qcom,mode-select", &mode); rc = of_property_read_u32(of_node, "qcom,mode-select", &mode);
if (rc) if (rc) {
chip->pwm_mode = -EINVAL;
goto read_opt_props; goto read_opt_props;
}
if (mode > PM_PWM_MODE_LPG || if (mode > PM_PWM_MODE_LPG ||
(mode == PM_PWM_MODE_PWM && found_pwm_subnode == 0) || (mode == PM_PWM_MODE_PWM && found_pwm_subnode == 0) ||