evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check

Browse source 
Only pin 0-7 support input, so the valid offset range should be 0 ~ 7.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
This commit is contained in:
Axel Lin 2014-04-15 10:54:11 +08:00 • committed by Matthew Garrett
parent 963649d735
commit 21a3542753
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/platform/x86/intel_pmic_gpio.c
View file

@ -91,7 +91,7 @@ static void pmic_program_irqtype(int gpio, int type)
static int pmic_gpio_direction_input(struct gpio_chip *chip, unsigned offset) static int pmic_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
{ {
if (offset > 8) { if (offset >= 8) {
pr_err("only pin 0-7 support input\n"); pr_err("only pin 0-7 support input\n");
return -1;/* we only have 8 GPIO can use as input */ return -1;/* we only have 8 GPIO can use as input */
} }
@ -130,7 +130,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned offset)
int ret; int ret;
/* we only have 8 GPIO pins we can use as input */ /* we only have 8 GPIO pins we can use as input */
if (offset > 8) if (offset >= 8)
return -EOPNOTSUPP; return -EOPNOTSUPP;
ret = intel_scu_ipc_ioread8(GPIO0 + offset, &r); ret = intel_scu_ipc_ioread8(GPIO0 + offset, &r);
if (ret < 0) if (ret < 0)