evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iwl3945-base.c: fix off-by-one errors

Browse source 
This patch fixes two off-by-one errors resulting in array overflows
spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Adrian Bunk 2008-02-02 23:19:01 +02:00 • committed by John W. Linville
parent 8dd0100ce9
commit 221c80cf03
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/net/wireless/iwlwifi/iwl3945-base.c
View file

@ -4207,13 +4207,13 @@ static u8 ratio2dB[100] = {
* Conversion assumes that levels are voltages (20*log), not powers (10*log). */ * Conversion assumes that levels are voltages (20*log), not powers (10*log). */
int iwl3945_calc_db_from_ratio(int sig_ratio) int iwl3945_calc_db_from_ratio(int sig_ratio)
{ {
/* Anything above 1000:1 just report as 60 dB */ /* 1000:1 or higher just report as 60 dB */
if (sig_ratio > 1000) if (sig_ratio >= 1000)
return 60; return 60;
/* Above 100:1, divide by 10 and use table, /* 100:1 or higher, divide by 10 and use table,
* add 20 dB to make up for divide by 10 */ * add 20 dB to make up for divide by 10 */
if (sig_ratio > 100) if (sig_ratio >= 100)
return (20 + (int)ratio2dB[sig_ratio/10]); return (20 + (int)ratio2dB[sig_ratio/10]);
/* We shouldn't see this */ /* We shouldn't see this */