evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gpio: vr41xx: fix up errorpath on probe()

Browse source 
The driver was not checking the return value from gpiochip_add()
properly, so add a bail-out check.

Reported-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Linus Walleij 2014-07-08 09:22:10 +02:00
parent 7cb5409b10
commit 246a144eed
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/gpio/gpio-vr41xx.c
View file

@ -515,7 +515,7 @@ static int giu_probe(struct platform_device *pdev)
struct resource *res; struct resource *res;
unsigned int trigger, i, pin; unsigned int trigger, i, pin;
struct irq_chip *chip; struct irq_chip *chip;
int irq, retval; int irq, ret;
switch (pdev->id) { switch (pdev->id) {
case GPIO_50PINS_PULLUPDOWN: case GPIO_50PINS_PULLUPDOWN:
@ -544,7 +544,11 @@ static int giu_probe(struct platform_device *pdev)
vr41xx_gpio_chip.dev = &pdev->dev; vr41xx_gpio_chip.dev = &pdev->dev;
retval = gpiochip_add(&vr41xx_gpio_chip); ret = gpiochip_add(&vr41xx_gpio_chip);
if (!ret) {
iounmap(giu_base);
return -ENODEV;
}
giu_write(GIUINTENL, 0); giu_write(GIUINTENL, 0);
giu_write(GIUINTENH, 0); giu_write(GIUINTENH, 0);