From 2a6a83e5be6bb07f056779db86d7e41bdbb9eecd Mon Sep 17 00:00:00 2001 From: Jeevan Shriram Date: Thu, 6 Aug 2015 16:06:13 -0700 Subject: [PATCH] msm: mdss: fix the input layer and layer list array index In the current implementation, wrong memory is being referenced while copying to user. Correct the input layer and layer list array index to avoid invalid memory access. CRs-Fixed: 882379 Change-Id: I47790d1c5419c099ce32727c28e5e6e7e742f18f Signed-off-by: Jeevan Shriram --- drivers/video/fbdev/msm/mdss_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/msm/mdss_fb.c b/drivers/video/fbdev/msm/mdss_fb.c index 9d673f3637f9..6c4c466d484f 100644 --- a/drivers/video/fbdev/msm/mdss_fb.c +++ b/drivers/video/fbdev/msm/mdss_fb.c @@ -3919,8 +3919,8 @@ static int mdss_fb_atomic_commit_ioctl(struct fb_info *info, if (layer_count) { for (j = 0; j < layer_count; j++) { - rc = copy_to_user(&input_layer_list[i].error_code, - &layer_list[i].error_code, sizeof(int)); + rc = copy_to_user(&input_layer_list[j].error_code, + &layer_list[j].error_code, sizeof(int)); if (rc) pr_err("layer error code copy to user failed\n"); }