evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

i7core_edac: Introduce free_i7core_dev

Browse source 
Have a method to make a couple with alloc_i7core_dev() previously
introduced.  Using in pair will help proper resource handling.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Hidetoshi Seto 2010-08-20 04:25:00 -03:00 • committed by Mauro Carvalho Chehab
parent 848b2f7ed6
commit 2aa9be448d
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/edac/i7core_edac.c
View file

@ -470,6 +470,13 @@ static struct i7core_dev *alloc_i7core_dev(u8 socket,
return i7core_dev; return i7core_dev;
} }
static void free_i7core_dev(struct i7core_dev *i7core_dev)
{
list_del(&i7core_dev->list);
kfree(i7core_dev->pdev);
kfree(i7core_dev);
}
/**************************************************************************** /****************************************************************************
Memory check routines Memory check routines
****************************************************************************/ ****************************************************************************/
@ -1265,7 +1272,6 @@ static void i7core_put_devices(struct i7core_dev *i7core_dev)
PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)); PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
pci_dev_put(pdev); pci_dev_put(pdev);
} }
kfree(i7core_dev->pdev);
} }
static void i7core_put_all_devices(void) static void i7core_put_all_devices(void)
@ -1274,8 +1280,7 @@ static void i7core_put_all_devices(void)
list_for_each_entry_safe(i7core_dev, tmp, &i7core_edac_list, list) { list_for_each_entry_safe(i7core_dev, tmp, &i7core_edac_list, list) {
i7core_put_devices(i7core_dev); i7core_put_devices(i7core_dev);
list_del(&i7core_dev->list); free_i7core_dev(i7core_dev);
kfree(i7core_dev);
} }
} }
@ -2106,8 +2111,7 @@ static void __devexit i7core_remove(struct pci_dev *pdev)
/* Release PCI resources */ /* Release PCI resources */
i7core_put_devices(i7core_dev); i7core_put_devices(i7core_dev);
list_del(&i7core_dev->list); free_i7core_dev(i7core_dev);
kfree(i7core_dev);
} }
} }
probed--; probed--;