evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iwlwifi: mvm: fix D3 firmware PN programming

Browse source 
The code to send the RX PN data (for each TID) to the firmware
has a devastating bug: it overwrites the data for TID 0 with
all the TID data, leaving the remaining TIDs zeroed. This will
allow replays to actually be accepted by the firmware, which
could allow waking up the system.

Cc: <stable@vger.kernel.org> [3.1+]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
This commit is contained in:
Johannes Berg 2015-09-15 14:36:09 +02:00 • committed by Luca Coelho
parent 5bd166872d
commit 2cf5eb3ab7
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/net/wireless/iwlwifi/mvm/d3.c
View file

@ -293,12 +293,12 @@ static void iwl_mvm_wowlan_program_keys(struct ieee80211_hw *hw,
u8 *pn = seq.ccmp.pn; u8 *pn = seq.ccmp.pn;
ieee80211_get_key_rx_seq(key, i, &seq); ieee80211_get_key_rx_seq(key, i, &seq);
aes_sc->pn = cpu_to_le64((u64)pn[5] | aes_sc[i].pn = cpu_to_le64((u64)pn[5] |
((u64)pn[4] << 8) | ((u64)pn[4] << 8) |
((u64)pn[3] << 16) | ((u64)pn[3] << 16) |
((u64)pn[2] << 24) | ((u64)pn[2] << 24) |
((u64)pn[1] << 32) | ((u64)pn[1] << 32) |
((u64)pn[0] << 40)); ((u64)pn[0] << 40));
} }
data->use_rsc_tsc = true; data->use_rsc_tsc = true;
break; break;