From 0e73a64179a0ed156f59086b88b198191405b482 Mon Sep 17 00:00:00 2001 From: Deepak Kushwah Date: Fri, 3 Mar 2017 18:25:41 +0530 Subject: [PATCH] msm vidc: Update flags for secure scaling control Secure scaling control is flagged as volatile which should not be beacause as per the documentation a volatile control changes continuously but this control value is updated from capabilities we got from the firmware which is not going to change later. Also as this control is volatile, when we try to get control on this, driver will try to get control for all the controls which are flagged as volatile. This might lead to generate session error as there are some controls which are specific to codec type but as they are flagged volatile driver will try to get control for them too and this will trigger session error from firmware. Change-Id: I42602eb8e20a6ae5ce90f9dbe938b0503c6a731e CRs-Fixed: 2015147 Signed-off-by: Deepak Kushwah --- drivers/media/platform/msm/vidc/msm_vdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/msm/vidc/msm_vdec.c b/drivers/media/platform/msm/vidc/msm_vdec.c index b7e2c297a1ad..24eb8fff905b 100644 --- a/drivers/media/platform/msm/vidc/msm_vdec.c +++ b/drivers/media/platform/msm/vidc/msm_vdec.c @@ -528,7 +528,6 @@ static struct msm_vidc_ctrl msm_vdec_ctrls[] = { .step = 1, .menu_skip_mask = 0, .qmenu = NULL, - .flags = V4L2_CTRL_FLAG_VOLATILE | V4L2_CTRL_FLAG_READ_ONLY, }, { .id = V4L2_CID_MPEG_VIDC_VIDEO_NON_SECURE_OUTPUT2,