evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mfd: dln2: A couple endian fixes

Browse source 
Sparse catches a couple endian bugs.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Dan Carpenter 2014-11-18 14:58:00 +02:00 • committed by Lee Jones
parent 00ee7a37fd
commit 2fc2b4846c
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/mfd/dln2.c
View file

@ -436,6 +436,7 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
struct device *dev = &dln2->interface->dev; struct device *dev = &dln2->interface->dev;
const unsigned long timeout = DLN2_USB_TIMEOUT * HZ / 1000; const unsigned long timeout = DLN2_USB_TIMEOUT * HZ / 1000;
struct dln2_mod_rx_slots *rxs = &dln2->mod_rx_slots[handle]; struct dln2_mod_rx_slots *rxs = &dln2->mod_rx_slots[handle];
int size;
spin_lock(&dln2->disconnect_lock); spin_lock(&dln2->disconnect_lock);
if (!dln2->disconnect) if (!dln2->disconnect)
@ -477,8 +478,9 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
/* if we got here we know that the response header has been checked */ /* if we got here we know that the response header has been checked */
rsp = rxc->urb->transfer_buffer; rsp = rxc->urb->transfer_buffer;
size = le16_to_cpu(rsp->hdr.size);
if (rsp->hdr.size < sizeof(*rsp)) { if (size < sizeof(*rsp)) {
ret = -EPROTO; ret = -EPROTO;
goto out_free_rx_slot; goto out_free_rx_slot;
} }
@ -493,8 +495,8 @@ static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
if (!ibuf) if (!ibuf)
goto out_free_rx_slot; goto out_free_rx_slot;
if (*ibuf_len > rsp->hdr.size - sizeof(*rsp)) if (*ibuf_len > size - sizeof(*rsp))
*ibuf_len = rsp->hdr.size - sizeof(*rsp); *ibuf_len = size - sizeof(*rsp);
memcpy(ibuf, rsp + 1, *ibuf_len); memcpy(ibuf, rsp + 1, *ibuf_len);