evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mtd: pmc551: fix signedness bug in init_pmc551()

Browse source 
Since "length" is a u32, the error handling below didn't work when
fixup_pmc551() returns -ENODEV.

	if ((length = fixup_pmc551(PCI_Device)) <= 0)

This patch changes both the type of "length" and the return type of
fixup_pmc551() to int.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
Xi Wang 2012-01-09 16:58:25 -05:00 • committed by David Woodhouse
parent 30ec5a2cb1
commit 2ff5e1532d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/mtd/devices/pmc551.c
View file

@ -359,7 +359,7 @@ static int pmc551_write(struct mtd_info *mtd, loff_t to, size_t len,
* mechanism * mechanism
* returns the size of the memory region found. * returns the size of the memory region found.
*/ */
static u32 fixup_pmc551(struct pci_dev *dev) static int fixup_pmc551(struct pci_dev *dev)
{ {
#ifdef CONFIG_MTD_PMC551_BUGFIX #ifdef CONFIG_MTD_PMC551_BUGFIX
u32 dram_data; u32 dram_data;
@ -669,7 +669,7 @@ static int __init init_pmc551(void)
struct mypriv *priv; struct mypriv *priv;
int found = 0; int found = 0;
struct mtd_info *mtd; struct mtd_info *mtd;
u32 length = 0; int length = 0;
if (msize) { if (msize) {
msize = (1 << (ffs(msize) - 1)) << 20; msize = (1 << (ffs(msize) - 1)) << 20;