evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

V4L/DVB: drivers/media/video: Use available error codes

Browse source 
Error codes are stored in rc, but the return value is always 0.  Return rc
instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Julia Lawall 2010-08-16 13:27:47 -03:00 • committed by Mauro Carvalho Chehab
parent f277097929
commit 3053814c1c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/media/video/zr364xx.c
View file

@ -572,7 +572,7 @@ static int zr364xx_got_frame(struct zr364xx_camera *cam, int jpgsize)
DBG("wakeup [buf/i] [%p/%d]\n", buf, buf->vb.i); DBG("wakeup [buf/i] [%p/%d]\n", buf, buf->vb.i);
unlock: unlock:
spin_unlock_irqrestore(&cam->slock, flags); spin_unlock_irqrestore(&cam->slock, flags);
return 0; return rc;
} }
/* this function moves the usb stream read pipe data /* this function moves the usb stream read pipe data