evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GFS2: Deletion of unnecessary checks before two function calls

Browse source 
The functions iput() and put_pid() test whether their argument is NULL
and then return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:
Markus Elfring 2014-11-18 11:31:23 +01:00 • committed by Steven Whitehouse
parent 2e60d7683c
commit 30badc9543
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/gfs2/glock.c
View file

@ -836,8 +836,7 @@ void gfs2_holder_reinit(unsigned int state, unsigned flags, struct gfs2_holder *
gh->gh_flags = flags; gh->gh_flags = flags;
gh->gh_iflags = 0; gh->gh_iflags = 0;
gh->gh_ip = _RET_IP_; gh->gh_ip = _RET_IP_;
if (gh->gh_owner_pid) put_pid(gh->gh_owner_pid);
put_pid(gh->gh_owner_pid);
gh->gh_owner_pid = get_pid(task_pid(current)); gh->gh_owner_pid = get_pid(task_pid(current));
} }