evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: dt2801: fix using uninitialized variable warnings

Browse source 
As pointed out by Fengguang Wu, the calls to dt2801_readdata() return the
data read thru a pointer (the address of a local variable) passed as a
parameter. If this local variable is not initialized it produces a warning
during the build of the form:

drivers/staging/comedi/drivers/dt2801.c: In function 'dt2801_ai_insn_read':
drivers/staging/comedi/drivers/dt2801.c:273:14: warning: 'hb' is used
      uninitialized in this function [-Wuninitialized]

Fix these warning by making sure the local variables are initialized.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-09-26 10:29:20 -07:00 • committed by Greg Kroah-Hartman
parent 48c8cd291c
commit 3389c99eb8
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/staging/comedi/drivers/dt2801.c
View file

@ -260,7 +260,8 @@ static int dt2801_readdata(struct comedi_device *dev, int *data)
static int dt2801_readdata2(struct comedi_device *dev, int *data) static int dt2801_readdata2(struct comedi_device *dev, int *data)
{ {
int lb, hb; int lb = 0;
int hb = 0;
int ret; int ret;
ret = dt2801_readdata(dev, &lb); ret = dt2801_readdata(dev, &lb);
@ -532,7 +533,7 @@ static int dt2801_dio_insn_bits(struct comedi_device *dev,
unsigned int *data) unsigned int *data)
{ {
int which = (s == &dev->subdevices[3]) ? 1 : 0; int which = (s == &dev->subdevices[3]) ? 1 : 0;
unsigned int val; unsigned int val = 0;
if (comedi_dio_update_state(s, data)) { if (comedi_dio_update_state(s, data)) {
dt2801_writecmd(dev, DT_C_WRITE_DIG); dt2801_writecmd(dev, DT_C_WRITE_DIG);