evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: et131x: Fix et131x smatch issues

Browse source 
This fixes the following issues:

et131x_initpci.c +488 et131x_adjust_link(45) error: we previously assumed 'phydev' could be null.
et131x_initpci.c +504 et131x_adjust_link(61) warn: variable dereferenced before check 'phydev'

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Mark Einon 2011-10-10 16:21:12 +01:00 • committed by Greg Kroah-Hartman
parent 6617c36987
commit 33fd472ee7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/et131x/et131x_initpci.c
View file

@ -485,7 +485,7 @@ static void et131x_adjust_link(struct net_device *netdev)
et1310_config_mac_regs2(adapter); et1310_config_mac_regs2(adapter);
} }
if (phydev->link != adapter->link) { if (phydev && phydev->link != adapter->link) {
/* /*
* Check to see if we are in coma mode and if * Check to see if we are in coma mode and if
* so, disable it because we will not be able * so, disable it because we will not be able
@ -501,7 +501,7 @@ static void et131x_adjust_link(struct net_device *netdev)
"Link down - cable problem ?\n"); "Link down - cable problem ?\n");
adapter->boot_coma = 0; adapter->boot_coma = 0;
if (phydev && phydev->speed == SPEED_10) { if (phydev->speed == SPEED_10) {
/* NOTE - Is there a way to query this without /* NOTE - Is there a way to query this without
* TruePHY? * TruePHY?
* && TRU_QueryCoreType(adapter->hTruePhy, 0) == * && TRU_QueryCoreType(adapter->hTruePhy, 0) ==