From c994a4d519b803bb144cbaf962baa8d2ec285421 Mon Sep 17 00:00:00 2001 From: Adithya Krishnamurthy Date: Tue, 15 Jul 2014 22:18:18 +0530 Subject: [PATCH 1/3] Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const Fixed checkpatch "WARNING: char * array declaration might be better as static const" Signed-off-by: Adithya Krishnamurthy Signed-off-by: Greg Kroah-Hartman --- drivers/staging/tidspbridge/core/io_sm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 42f94e157efd..24bd962e1474 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -1910,10 +1910,11 @@ int dump_dsp_stack(struct bridge_dev_context *bridge_context) u32 offset_output; u32 total_size; u32 poll_cnt; - const char *dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR", + static const char * const dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR", "IRP", "NRP", "AMR", "SSR", "ILC", "RILC", "IER", "CSR"}; - const char *exec_ctxt[] = {"Task", "SWI", "HWI", "Unknown"}; + static const char * const exec_ctxt[] = {"Task", "SWI", "HWI", + "Unknown"}; struct bridge_drv_interface *intf_fxns; struct dev_object *dev_object = bridge_context->dev_obj; From 573954d37742de4efcd4a53bf1454af9a928bb29 Mon Sep 17 00:00:00 2001 From: Adithya Krishnamurthy Date: Tue, 15 Jul 2014 22:18:19 +0530 Subject: [PATCH 2/3] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline Fixed checkpatch "WARNING: unnecessary whitespace before a quoted newline" Signed-off-by: Adithya Krishnamurthy Signed-off-by: Greg Kroah-Hartman --- drivers/staging/tidspbridge/core/tiomap3430.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f63dd8f4dde9..0559ab63b63e 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++ b/drivers/staging/tidspbridge/core/tiomap3430.c @@ -536,7 +536,7 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt, if ((unsigned int *)ul_dsp_clk_addr != NULL) { /* Get the clock rate */ ul_dsp_clk_rate = dsp_clk_get_iva2_rate(); - dev_dbg(bridge, "%s: DSP clock rate (KHZ): 0x%x \n", + dev_dbg(bridge, "%s: DSP clock rate (KHZ): 0x%x\n", __func__, ul_dsp_clk_rate); (void)bridge_brd_write(dev_context, (u8 *) &ul_dsp_clk_rate, From 3b9a1ded5eb2b7c13f98988542d19472d1784a93 Mon Sep 17 00:00:00 2001 From: Adithya Krishnamurthy Date: Tue, 15 Jul 2014 22:18:20 +0530 Subject: [PATCH 3/3] Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses Fixed checkpatch "WARNING: Unnecessary parentheses" Signed-off-by: Adithya Krishnamurthy Signed-off-by: Greg Kroah-Hartman --- drivers/staging/tidspbridge/dynload/cload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/dynload/cload.c b/drivers/staging/tidspbridge/dynload/cload.c index 83f2106ff8a7..b306349c2267 100644 --- a/drivers/staging/tidspbridge/dynload/cload.c +++ b/drivers/staging/tidspbridge/dynload/cload.c @@ -376,7 +376,7 @@ void dload_headers(struct dload_state *dlthis) return; } /* Check for valid file format */ - if ((dlthis->dfile_hdr.df_doff_version != DOFF0)) { + if (dlthis->dfile_hdr.df_doff_version != DOFF0) { dload_error(dlthis, "Bad DOFF version 0x%x", dlthis->dfile_hdr.df_doff_version); return;