evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: addi_apci_3xxx: tidy up the ttl digital i/o subdevice init

Browse source 
For aesthetic reasons, add some whitespace to the initialization of the
ttl digital i/o subdevices.

Fix the subdev_flags for the subdevice. The SDF_GROUND and SDF_COMMON
flags only apply to analog subdevices.

Fix the s->iobits for the subdevice. According to the datasheet:
	Port 0 (channels 0-7) are always outputs
	Port 1 (channels 8-15) are always inputs
	Port 2 (channels 9-23) are programmable i/o (default to inputs)

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-06-12 16:14:02 -07:00 • committed by Greg Kroah-Hartman
parent ca1cc85b0e
commit 383390cfd4
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/staging/comedi/drivers/addi_apci_3xxx.c
View file

@ -596,15 +596,14 @@ static int apci3xxx_auto_attach(struct comedi_device *dev,
s = &dev->subdevices[4]; s = &dev->subdevices[4];
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
/* Allocate and Initialise TTL */ /* TTL Digital I/O subdevice */
s = &dev->subdevices[5]; s = &dev->subdevices[5];
if (board->has_ttl_io) { if (board->has_ttl_io) {
s->type = COMEDI_SUBD_DIO; s->type = COMEDI_SUBD_DIO;
s->subdev_flags = s->subdev_flags = SDF_READABLE | SDF_WRITEABLE;
SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = 24; s->n_chan = 24;
s->maxdata = 1; s->maxdata = 1;
s->io_bits = 0; /* all bits input */ s->io_bits = 0xff; /* channels 0-7 are always outputs */
s->range_table = &range_digital; s->range_table = &range_digital;
s->insn_config = i_APCI3XXX_InsnConfigInitTTLIO; s->insn_config = i_APCI3XXX_InsnConfigInitTTLIO;
s->insn_bits = i_APCI3XXX_InsnBitsTTLIO; s->insn_bits = i_APCI3XXX_InsnBitsTTLIO;