evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: unisys: clean up NULL compares in virtpci.c

Browse source 
Remove unnecessary NULLs by just using the pointer value directly.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Benjamin Romer 2015-03-16 13:57:49 -04:00 • committed by Greg Kroah-Hartman
parent c394650650
commit 3d8dbdbfed
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/unisys/virtpci/virtpci.c
View file

@ -809,7 +809,7 @@ static int virtpci_device_add(struct device *parentbus, int devtype,
/* add a Virtual Device */ /* add a Virtual Device */
virtpcidev = kzalloc(sizeof(*virtpcidev), GFP_ATOMIC); virtpcidev = kzalloc(sizeof(*virtpcidev), GFP_ATOMIC);
if (virtpcidev == NULL) { if (!virtpcidev) {
POSTCODE_LINUX_2(MALLOC_FAILURE_PC, POSTCODE_SEVERITY_ERR); POSTCODE_LINUX_2(MALLOC_FAILURE_PC, POSTCODE_SEVERITY_ERR);
return 0; return 0;
} }
@ -1076,8 +1076,8 @@ static int virtpci_device_del(struct device *parentbus,
/* see if we are to delete all - NOTE: all implies we have a /* see if we are to delete all - NOTE: all implies we have a
* valid parentbus * valid parentbus
*/ */
all = ((devtype == VIRTHBA_TYPE) && (wwnn == NULL)) || all = ((devtype == VIRTHBA_TYPE) && (!wwnn)) ||
((devtype == VIRTNIC_TYPE) && (macaddr == NULL)); ((devtype == VIRTNIC_TYPE) && (!macaddr));
/* find all the vhba or vnic or both in virtpci device list /* find all the vhba or vnic or both in virtpci device list
* keep list of ones we are deleting so we can call * keep list of ones we are deleting so we can call
@ -1206,9 +1206,8 @@ int virtpci_register_driver(struct virtpci_driver *drv)
{ {
int result = 0; int result = 0;
if (drv->id_table == NULL) if (!drv->id_table)
return 1; return 1;
/* initialize core driver fields needed to call driver_register */ /* initialize core driver fields needed to call driver_register */
drv->core_driver.name = drv->name; /* name of driver in sysfs */ drv->core_driver.name = drv->name; /* name of driver in sysfs */
drv->core_driver.bus = &virtpci_bus_type; /* type of bus this drv->core_driver.bus = &virtpci_bus_type; /* type of bus this