evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

usb: ehci-omap: Show fatal probing time errors to end user

Browse source 
There are a few error paths in ehci_hcd_omap_probe that can be triggered
because of memory allocation or hw failure. Change those dev_dbg error
prints to dev_err with an error code printed so that the end users are able
to notice the issue.

Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Jarkko Nikula 2011-01-07 11:19:52 +02:00 • committed by Felipe Balbi
parent 5f5761cb8e
commit 3e434a86cb
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/usb/host/ehci-omap.c
View file

@ -796,7 +796,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
hcd = usb_create_hcd(&ehci_omap_hc_driver, &pdev->dev, hcd = usb_create_hcd(&ehci_omap_hc_driver, &pdev->dev,
dev_name(&pdev->dev)); dev_name(&pdev->dev));
if (!hcd) { if (!hcd) {
dev_dbg(&pdev->dev, "failed to create hcd with err %d\n", ret); dev_err(&pdev->dev, "failed to create hcd with err %d\n", ret);
ret = -ENOMEM; ret = -ENOMEM;
goto err_create_hcd; goto err_create_hcd;
} }
@ -864,7 +864,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
ret = omap_start_ehc(omap, hcd); ret = omap_start_ehc(omap, hcd);
if (ret) { if (ret) {
dev_dbg(&pdev->dev, "failed to start ehci\n"); dev_err(&pdev->dev, "failed to start ehci with err %d\n", ret);
goto err_start; goto err_start;
} }
@ -879,7 +879,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
ret = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED); ret = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED);
if (ret) { if (ret) {
dev_dbg(&pdev->dev, "failed to add hcd with err %d\n", ret); dev_err(&pdev->dev, "failed to add hcd with err %d\n", ret);
goto err_add_hcd; goto err_add_hcd;
} }