From 3fdd8450ea0b7bf902d2024734a8c5e04a1c93f0 Mon Sep 17 00:00:00 2001 From: Veera Sundaram Sankaran Date: Thu, 13 Aug 2015 15:29:55 -0700 Subject: [PATCH] msm: mdss: fix error checking for dma_map_sg_lazy dma_map_sg_lazy returns the nents value, ie the number of entries in sglist which is passed on success. Error checking should be done based on nents value and not on non-zero return value. Change-Id: I341990fcd4eb123306fb8d1c3b08be85f0b7764b Signed-off-by: Veera Sundaram Sankaran --- drivers/video/fbdev/msm/mdss_smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/msm/mdss_smmu.c b/drivers/video/fbdev/msm/mdss_smmu.c index 762ee72c2e23..8bb46fad7875 100644 --- a/drivers/video/fbdev/msm/mdss_smmu.c +++ b/drivers/video/fbdev/msm/mdss_smmu.c @@ -265,7 +265,7 @@ static int mdss_smmu_map_dma_buf_v2(struct dma_buf *dma_buf, ATRACE_BEGIN("map_buffer"); rc = msm_dma_map_sg_lazy(mdss_smmu->dev, table->sgl, table->nents, dir, dma_buf); - if (!rc) { + if (rc != table->nents) { pr_err("dma map sg failed\n"); return -ENOMEM; }