evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drbd: fix conn_reconfig_start without conn_reconfig_done in drbd_adm_attach

Browse source 
If drbd_adm_attach failed early, it left the CONFIG_PENDING bit on,
blocking any further conn_reconfig_start on that connection.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
This commit is contained in:
Lars Ellenberg 2011-03-16 16:52:10 +01:00 • committed by Philipp Reisner
parent e4f78edee1
commit 40cbf085f5
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/block/drbd/drbd_nl.c
View file

@ -1041,7 +1041,7 @@ int drbd_adm_attach(struct sk_buff *skb, struct genl_info *info)
if (!adm_ctx.reply_skb) if (!adm_ctx.reply_skb)
return retcode; return retcode;
if (retcode != NO_ERROR) if (retcode != NO_ERROR)
goto fail; goto finish;
mdev = adm_ctx.mdev; mdev = adm_ctx.mdev;
conn_reconfig_start(mdev->tconn); conn_reconfig_start(mdev->tconn);
@ -1400,8 +1400,8 @@ int drbd_adm_attach(struct sk_buff *skb, struct genl_info *info)
force_diskless: force_diskless:
drbd_force_state(mdev, NS(disk, D_FAILED)); drbd_force_state(mdev, NS(disk, D_FAILED));
drbd_md_sync(mdev); drbd_md_sync(mdev);
conn_reconfig_done(mdev->tconn);
fail: fail:
conn_reconfig_done(mdev->tconn);
if (nbc) { if (nbc) {
if (nbc->backing_bdev) if (nbc->backing_bdev)
blkdev_put(nbc->backing_bdev, blkdev_put(nbc->backing_bdev,
@ -1413,6 +1413,7 @@ int drbd_adm_attach(struct sk_buff *skb, struct genl_info *info)
} }
lc_destroy(resync_lru); lc_destroy(resync_lru);
finish:
drbd_adm_finish(info, retcode); drbd_adm_finish(info, retcode);
return 0; return 0;
} }