evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xfs: tone down writepage/releasepage WARN_ONs

Browse source 
I recently ran into the issue fixed by

  "xfs: kill buffers over failed write ranges properly"

which spams the log with lots of backtraces.  Make debugging any
issues like that easier by using WARN_ON_ONCE in the writeback code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Christoph Hellwig 2014-06-06 16:05:15 +10:00 • committed by Dave Chinner
parent 72208ee060
commit 448011e2ab
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
fs/xfs/xfs_aops.c
View file

@ -975,7 +975,7 @@ xfs_vm_writepage(
* Given that we do not allow direct reclaim to call us, we should * Given that we do not allow direct reclaim to call us, we should
* never be called while in a filesystem transaction. * never be called while in a filesystem transaction.
*/ */
if (WARN_ON(current->flags & PF_FSTRANS)) if (WARN_ON_ONCE(current->flags & PF_FSTRANS))
goto redirty; goto redirty;
/* Is this page beyond the end of the file? */ /* Is this page beyond the end of the file? */
@ -1188,9 +1188,9 @@ xfs_vm_releasepage(
xfs_count_page_state(page, &delalloc, &unwritten); xfs_count_page_state(page, &delalloc, &unwritten);
if (WARN_ON(delalloc)) if (WARN_ON_ONCE(delalloc))
return 0; return 0;
if (WARN_ON(unwritten)) if (WARN_ON_ONCE(unwritten))
return 0; return 0;
return try_to_free_buffers(page); return try_to_free_buffers(page);