From 6ab2197424c24a26433606d26575d54c68694623 Mon Sep 17 00:00:00 2001 From: Gaurav Kohli Date: Mon, 12 Jun 2017 19:25:31 +0530 Subject: [PATCH] firmware_class: Avoid memory leak when FW_OPT_NOCACHE is set During call of request_firmware_into_buf, if FW_OPT_NOCACHE is set then release_firmware skip freeing of fw_id. So explicitly freeing the same to avoid memory leak. Change-Id: I7e1d6f8f06c4532b2bcbf256267fd1e90f5ced70 Signed-off-by: Gaurav Kohli --- drivers/base/firmware_class.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 212ca2eee257..68561696f31b 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -295,6 +295,7 @@ static void fw_free_buf(struct firmware_buf *buf) { struct firmware_cache *fwc = buf->fwc; if (!fwc) { + kfree_const(buf->fw_id); kfree(buf); return; }