evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: fix races in page->_count manipulation

Browse source 
This is illegal to use atomic_set(&page->_count, ...) even if we 'own'
the page. Other entities in the kernel need to use get_page_unless_zero()
to get a reference to the page before testing page properties, so we could
loose a refcount increment.

The only case it is valid is when page->_count is 0

Fixes: 540eb7bf0b ("net: Update alloc frag to reduce get/put page usage and recycle pages")
Signed-off-by: Eric Dumaze <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2014-10-10 04:48:18 -07:00 • committed by David S. Miller
parent 98226208c8
commit 4c450583d9
1 changed files with 18 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
net/core/skbuff.c
View file

@ -360,18 +360,29 @@ refill:
goto end; goto end;
} }
nc->frag.size = PAGE_SIZE << order; nc->frag.size = PAGE_SIZE << order;
recycle: /* Even if we own the page, we do not use atomic_set().
atomic_set(&nc->frag.page->_count, NETDEV_PAGECNT_MAX_BIAS); * This would break get_page_unless_zero() users.
*/
atomic_add(NETDEV_PAGECNT_MAX_BIAS - 1,
&nc->frag.page->_count);
nc->pagecnt_bias = NETDEV_PAGECNT_MAX_BIAS; nc->pagecnt_bias = NETDEV_PAGECNT_MAX_BIAS;
nc->frag.offset = 0; nc->frag.offset = 0;
} }
if (nc->frag.offset + fragsz > nc->frag.size) { if (nc->frag.offset + fragsz > nc->frag.size) {
/* avoid unnecessary locked operations if possible */ if (atomic_read(&nc->frag.page->_count) != nc->pagecnt_bias) {
if ((atomic_read(&nc->frag.page->_count) == nc->pagecnt_bias) || if (!atomic_sub_and_test(nc->pagecnt_bias,
atomic_sub_and_test(nc->pagecnt_bias, &nc->frag.page->_count)) &nc->frag.page->_count))
goto recycle;
goto refill; goto refill;
/* OK, page count is 0, we can safely set it */
atomic_set(&nc->frag.page->_count,
NETDEV_PAGECNT_MAX_BIAS);
} else {
atomic_add(NETDEV_PAGECNT_MAX_BIAS - nc->pagecnt_bias,
&nc->frag.page->_count);
}
nc->pagecnt_bias = NETDEV_PAGECNT_MAX_BIAS;
nc->frag.offset = 0;
} }
data = page_address(nc->frag.page) + nc->frag.offset; data = page_address(nc->frag.page) + nc->frag.offset;