dm io: write error bits form long not int
write_err is an unsigned long used with set_bit() so should not be passed around as unsigned int. http://bugzilla.kernel.org/show_bug.cgi?id=10271 Signed-off-by: Alasdair G Kergon <agk@redhat.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
d250dad64a
commit
4cdc1d1fa5
5 changed files with 11 additions and 11 deletions
|
@ -114,7 +114,7 @@ static void dec_count(struct io *io, unsigned int region, int error)
|
||||||
wake_up_process(io->sleeper);
|
wake_up_process(io->sleeper);
|
||||||
|
|
||||||
else {
|
else {
|
||||||
int r = io->error;
|
unsigned long r = io->error;
|
||||||
io_notify_fn fn = io->callback;
|
io_notify_fn fn = io->callback;
|
||||||
void *context = io->context;
|
void *context = io->context;
|
||||||
|
|
||||||
|
|
|
@ -753,7 +753,7 @@ out:
|
||||||
* are in the no-sync state. We have to recover these by
|
* are in the no-sync state. We have to recover these by
|
||||||
* recopying from the default mirror to all the others.
|
* recopying from the default mirror to all the others.
|
||||||
*---------------------------------------------------------------*/
|
*---------------------------------------------------------------*/
|
||||||
static void recovery_complete(int read_err, unsigned int write_err,
|
static void recovery_complete(int read_err, unsigned long write_err,
|
||||||
void *context)
|
void *context)
|
||||||
{
|
{
|
||||||
struct region *reg = (struct region *)context;
|
struct region *reg = (struct region *)context;
|
||||||
|
@ -767,7 +767,7 @@ static void recovery_complete(int read_err, unsigned int write_err,
|
||||||
}
|
}
|
||||||
|
|
||||||
if (write_err) {
|
if (write_err) {
|
||||||
DMERR_LIMIT("Write error during recovery (error = 0x%x)",
|
DMERR_LIMIT("Write error during recovery (error = 0x%lx)",
|
||||||
write_err);
|
write_err);
|
||||||
/*
|
/*
|
||||||
* Bits correspond to devices (excluding default mirror).
|
* Bits correspond to devices (excluding default mirror).
|
||||||
|
|
|
@ -804,7 +804,7 @@ static void commit_callback(void *context, int success)
|
||||||
* Called when the copy I/O has finished. kcopyd actually runs
|
* Called when the copy I/O has finished. kcopyd actually runs
|
||||||
* this code so don't block.
|
* this code so don't block.
|
||||||
*/
|
*/
|
||||||
static void copy_callback(int read_err, unsigned int write_err, void *context)
|
static void copy_callback(int read_err, unsigned long write_err, void *context)
|
||||||
{
|
{
|
||||||
struct dm_snap_pending_exception *pe = context;
|
struct dm_snap_pending_exception *pe = context;
|
||||||
struct dm_snapshot *s = pe->snap;
|
struct dm_snapshot *s = pe->snap;
|
||||||
|
|
|
@ -169,7 +169,7 @@ struct kcopyd_job {
|
||||||
* Error state of the job.
|
* Error state of the job.
|
||||||
*/
|
*/
|
||||||
int read_err;
|
int read_err;
|
||||||
unsigned int write_err;
|
unsigned long write_err;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Either READ or WRITE
|
* Either READ or WRITE
|
||||||
|
@ -293,7 +293,7 @@ static int run_complete_job(struct kcopyd_job *job)
|
||||||
{
|
{
|
||||||
void *context = job->context;
|
void *context = job->context;
|
||||||
int read_err = job->read_err;
|
int read_err = job->read_err;
|
||||||
unsigned int write_err = job->write_err;
|
unsigned long write_err = job->write_err;
|
||||||
kcopyd_notify_fn fn = job->fn;
|
kcopyd_notify_fn fn = job->fn;
|
||||||
struct kcopyd_client *kc = job->kc;
|
struct kcopyd_client *kc = job->kc;
|
||||||
|
|
||||||
|
@ -396,7 +396,7 @@ static int process_jobs(struct list_head *jobs, int (*fn) (struct kcopyd_job *))
|
||||||
if (r < 0) {
|
if (r < 0) {
|
||||||
/* error this rogue job */
|
/* error this rogue job */
|
||||||
if (job->rw == WRITE)
|
if (job->rw == WRITE)
|
||||||
job->write_err = (unsigned int) -1;
|
job->write_err = (unsigned long) -1L;
|
||||||
else
|
else
|
||||||
job->read_err = 1;
|
job->read_err = 1;
|
||||||
push(&_complete_jobs, job);
|
push(&_complete_jobs, job);
|
||||||
|
@ -448,8 +448,8 @@ static void dispatch_job(struct kcopyd_job *job)
|
||||||
}
|
}
|
||||||
|
|
||||||
#define SUB_JOB_SIZE 128
|
#define SUB_JOB_SIZE 128
|
||||||
static void segment_complete(int read_err,
|
static void segment_complete(int read_err, unsigned long write_err,
|
||||||
unsigned int write_err, void *context)
|
void *context)
|
||||||
{
|
{
|
||||||
/* FIXME: tidy this function */
|
/* FIXME: tidy this function */
|
||||||
sector_t progress = 0;
|
sector_t progress = 0;
|
||||||
|
|
|
@ -32,8 +32,8 @@ void kcopyd_client_destroy(struct kcopyd_client *kc);
|
||||||
* read_err is a boolean,
|
* read_err is a boolean,
|
||||||
* write_err is a bitset, with 1 bit for each destination region
|
* write_err is a bitset, with 1 bit for each destination region
|
||||||
*/
|
*/
|
||||||
typedef void (*kcopyd_notify_fn)(int read_err,
|
typedef void (*kcopyd_notify_fn)(int read_err, unsigned long write_err,
|
||||||
unsigned int write_err, void *context);
|
void *context);
|
||||||
|
|
||||||
int kcopyd_copy(struct kcopyd_client *kc, struct io_region *from,
|
int kcopyd_copy(struct kcopyd_client *kc, struct io_region *from,
|
||||||
unsigned int num_dests, struct io_region *dests,
|
unsigned int num_dests, struct io_region *dests,
|
||||||
|
|
Loading…
Add table
Reference in a new issue