evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: usbduxsigma: tidy up usbdux_pwm_write()

Browse source 
Rename the function so it has namespace associated with the driver.

Tidy up the comments.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-05-23 12:58:23 -07:00 • committed by Greg Kroah-Hartman
parent 92f687ba5e
commit 4ced8c641e
1 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
drivers/staging/comedi/drivers/usbduxsigma.c
View file

@ -1366,24 +1366,25 @@ static int usbdux_pwm_pattern(struct comedi_device *dev,
return 1; return 1;
} }
static int usbdux_pwm_write(struct comedi_device *dev, static int usbduxsigma_pwm_write(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn,
unsigned int *data)
{ {
if ((insn->n) != 1) { unsigned int chan = CR_CHAN(insn->chanspec);
/*
* doesn't make sense to have more than one value here because
* it would just overwrite the PWM buffer a couple of times
*/
return -EINVAL;
}
/* /*
* the sign is set via a special INSN only, this gives us 8 bits for * It doesn't make sense to support more than one value here
* normal operation * because it would just overwrite the PWM buffer.
* relay sign 0 by default
*/ */
return usbdux_pwm_pattern(dev, s, CR_CHAN(insn->chanspec), data[0], 0); if (insn->n != 1)
return -EINVAL;
/*
* The sign is set via a special INSN only, this gives us 8 bits
* for normal operation, sign is 0 by default.
*/
return usbdux_pwm_pattern(dev, s, chan, data[0], 0);
} }
static int usbduxsigma_pwm_config(struct comedi_device *dev, static int usbduxsigma_pwm_config(struct comedi_device *dev,
@ -1543,7 +1544,7 @@ static int usbduxsigma_attach_common(struct comedi_device *dev)
s->subdev_flags = SDF_WRITABLE | SDF_PWM_HBRIDGE; s->subdev_flags = SDF_WRITABLE | SDF_PWM_HBRIDGE;
s->n_chan = 8; s->n_chan = 8;
s->maxdata = devpriv->sizePwmBuf; s->maxdata = devpriv->sizePwmBuf;
s->insn_write = usbdux_pwm_write; s->insn_write = usbduxsigma_pwm_write;
s->insn_config = usbduxsigma_pwm_config; s->insn_config = usbduxsigma_pwm_config;
usbdux_pwm_period(dev, s, PWM_DEFAULT_PERIOD); usbdux_pwm_period(dev, s, PWM_DEFAULT_PERIOD);