From 4e02797d45d304818f0f5b0b4e5b72f2d5d08a19 Mon Sep 17 00:00:00 2001 From: Shantanu Jain Date: Thu, 3 Oct 2013 14:28:37 +0530 Subject: [PATCH] input: touchscreen: Correct return value check in Goodix driver Correct return value check of gtp_read_fw_version, called in probe of the Goodix driver. The return value is actually the number of registers read through gtp_i2c_read() function call. Also change the error message of gtp_check_product_id. Change-Id: I0b643e250a487f08a19555237802b020b0873d1a Signed-off-by: Shantanu Jain --- drivers/input/touchscreen/gt9xx/gt9xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/gt9xx/gt9xx.c b/drivers/input/touchscreen/gt9xx/gt9xx.c index 76250b87204d..4d71d474c113 100644 --- a/drivers/input/touchscreen/gt9xx/gt9xx.c +++ b/drivers/input/touchscreen/gt9xx/gt9xx.c @@ -1057,7 +1057,7 @@ static int gtp_check_product_id(struct i2c_client *client) ret = gtp_i2c_read(client, buf, sizeof(buf)); if (ret < 0) { - dev_err(&client->dev, "GTP read version failed.\n"); + dev_err(&client->dev, "GTP read product_id failed.\n"); return -EIO; } @@ -1740,7 +1740,7 @@ static int goodix_ts_probe(struct i2c_client *client, dev_info(&client->dev, "GTP works in interrupt mode.\n"); ret = gtp_read_fw_version(client, &version_info); - if (ret != 0) + if (ret != 2) dev_err(&client->dev, "GTP firmware version read failed.\n"); ret = gtp_check_product_id(client);