evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hso: replace current->state by __set_current_state()

Browse source 
Use helper functions to access current->state.
Direct assignments are prone to races and therefore buggy.

Thanks to Peter Zijlstra for the exact definition of the problem.

Suggested-By: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Fabian Frederick 2015-02-20 19:12:55 +01:00 • committed by David S. Miller
parent 45cee4f594
commit 50462ce005
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/usb/hso.c
View file

@ -1594,7 +1594,7 @@ hso_wait_modem_status(struct hso_serial *serial, unsigned long arg)
} }
cprev = cnow; cprev = cnow;
} }
current->state = TASK_RUNNING; __set_current_state(TASK_RUNNING);
remove_wait_queue(&tiocmget->waitq, &wait); remove_wait_queue(&tiocmget->waitq, &wait);
return ret; return ret;