evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ata: ahci_platform: fix devm_ioremap_resource() return value checking

Browse source 
devm_ioremap_resource() returns a pointer to the remapped memory or
an ERR_PTR() encoded error code on failure.  Fix the check inside
ahci_platform_get_resources() accordingly.

Also while at it remove a needless line break.

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Bartlomiej Zolnierkiewicz 2014-03-14 18:22:09 +01:00 • committed by Tejun Heo
parent 13e8e78bdd
commit 5434b20315
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/ata/ahci_platform.c
View file

@ -199,8 +199,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
* RETURNS: * RETURNS:
* The allocated ahci_host_priv on success, otherwise an ERR_PTR value * The allocated ahci_host_priv on success, otherwise an ERR_PTR value
*/ */
struct ahci_host_priv *ahci_platform_get_resources( struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct ahci_host_priv *hpriv; struct ahci_host_priv *hpriv;
@ -219,8 +218,9 @@ struct ahci_host_priv *ahci_platform_get_resources(
hpriv->mmio = devm_ioremap_resource(dev, hpriv->mmio = devm_ioremap_resource(dev,
platform_get_resource(pdev, IORESOURCE_MEM, 0)); platform_get_resource(pdev, IORESOURCE_MEM, 0));
if (!hpriv->mmio) { if (IS_ERR(hpriv->mmio)) {
dev_err(dev, "no mmio space\n"); dev_err(dev, "no mmio space\n");
rc = PTR_ERR(hpriv->mmio);
goto err_out; goto err_out;
} }