x86/asm/entry/32: Tidy up JNZ instructions after TESTs
After TESTs, use logically correct JNZ mnemonic instead of JNE. This doesn't change code: md5: c3005b39a11fe582b7df7908561ad4ee entry_32.o.before.asm c3005b39a11fe582b7df7908561ad4ee entry_32.o.after.asm Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> Acked-by: Andy Lutomirski <luto@kernel.org> Cc: Alexei Starovoitov <ast@plumgrid.com> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@alien8.de> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Kees Cook <keescook@chromium.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Will Drewry <wad@chromium.org> Link: http://lkml.kernel.org/r/1428689620-21881-1-git-send-email-dvlasenk@redhat.com [ Added object file comparison. ] Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
parent
a37f34a325
commit
54cfa458b4
1 changed files with 5 additions and 5 deletions
|
@ -435,7 +435,7 @@ sysenter_after_call:
|
||||||
TRACE_IRQS_OFF
|
TRACE_IRQS_OFF
|
||||||
movl TI_flags(%ebp), %ecx
|
movl TI_flags(%ebp), %ecx
|
||||||
testl $_TIF_ALLWORK_MASK, %ecx
|
testl $_TIF_ALLWORK_MASK, %ecx
|
||||||
jne sysexit_audit
|
jnz sysexit_audit
|
||||||
sysenter_exit:
|
sysenter_exit:
|
||||||
/* if something modifies registers it must also disable sysexit */
|
/* if something modifies registers it must also disable sysexit */
|
||||||
movl PT_EIP(%esp), %edx
|
movl PT_EIP(%esp), %edx
|
||||||
|
@ -463,7 +463,7 @@ sysenter_audit:
|
||||||
|
|
||||||
sysexit_audit:
|
sysexit_audit:
|
||||||
testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %ecx
|
testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %ecx
|
||||||
jne syscall_exit_work
|
jnz syscall_exit_work
|
||||||
TRACE_IRQS_ON
|
TRACE_IRQS_ON
|
||||||
ENABLE_INTERRUPTS(CLBR_ANY)
|
ENABLE_INTERRUPTS(CLBR_ANY)
|
||||||
movl %eax,%edx /* second arg, syscall return value */
|
movl %eax,%edx /* second arg, syscall return value */
|
||||||
|
@ -475,7 +475,7 @@ sysexit_audit:
|
||||||
TRACE_IRQS_OFF
|
TRACE_IRQS_OFF
|
||||||
movl TI_flags(%ebp), %ecx
|
movl TI_flags(%ebp), %ecx
|
||||||
testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %ecx
|
testl $(_TIF_ALLWORK_MASK & ~_TIF_SYSCALL_AUDIT), %ecx
|
||||||
jne syscall_exit_work
|
jnz syscall_exit_work
|
||||||
movl PT_EAX(%esp),%eax /* reload syscall return value */
|
movl PT_EAX(%esp),%eax /* reload syscall return value */
|
||||||
jmp sysenter_exit
|
jmp sysenter_exit
|
||||||
#endif
|
#endif
|
||||||
|
@ -513,7 +513,7 @@ syscall_exit:
|
||||||
TRACE_IRQS_OFF
|
TRACE_IRQS_OFF
|
||||||
movl TI_flags(%ebp), %ecx
|
movl TI_flags(%ebp), %ecx
|
||||||
testl $_TIF_ALLWORK_MASK, %ecx # current->work
|
testl $_TIF_ALLWORK_MASK, %ecx # current->work
|
||||||
jne syscall_exit_work
|
jnz syscall_exit_work
|
||||||
|
|
||||||
restore_all:
|
restore_all:
|
||||||
TRACE_IRQS_IRET
|
TRACE_IRQS_IRET
|
||||||
|
@ -615,7 +615,7 @@ work_notifysig: # deal with pending signals and
|
||||||
#ifdef CONFIG_VM86
|
#ifdef CONFIG_VM86
|
||||||
testl $X86_EFLAGS_VM, PT_EFLAGS(%esp)
|
testl $X86_EFLAGS_VM, PT_EFLAGS(%esp)
|
||||||
movl %esp, %eax
|
movl %esp, %eax
|
||||||
jne work_notifysig_v86 # returning to kernel-space or
|
jnz work_notifysig_v86 # returning to kernel-space or
|
||||||
# vm86-space
|
# vm86-space
|
||||||
1:
|
1:
|
||||||
#else
|
#else
|
||||||
|
|
Loading…
Add table
Reference in a new issue