evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

msm: mdss: fix potential deadlock with ulps work thread

Browse source 
Do not check if the clocks are on when sending the ULPS event from
the worker thread. This check is not needed since the work is only
scheduled after the clocks are turned off and would be cancelled
anyway when the clocks are turned on if it is pending. Removing this
unnecessary check avoids acquiring a shared lock which can potentially
lead to a deadlock.

Change-Id: Ib9760221f044dded50a38a32b59d0158c2f6b50e
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
This commit is contained in:
Aravind Venkateswaran 2014-05-08 12:30:38 -07:00 • committed by David Keitel
parent 58e6d3f6c9
commit 57cc7b9c67
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/video/fbdev/msm/mdss_mdp_intf_cmd.c
View file

@ -391,14 +391,6 @@ static void __mdss_mdp_cmd_ulps_work(struct work_struct *work)
return;
}
mutex_lock(&ctx->clk_mtx);
if (ctx->clk_enabled) {
mutex_unlock(&ctx->clk_mtx);
pr_warn("Cannot enter ulps mode if DSI clocks are on\n");
return;
}
mutex_unlock(&ctx->clk_mtx);
if (!ctx->panel_on) {
pr_err("Panel is off. skipping ULPS configuration\n");
return;